Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export cleanup method for did-intersect mock #416

Open
elwayman02 opened this issue Jul 26, 2021 · 0 comments
Open

Export cleanup method for did-intersect mock #416

elwayman02 opened this issue Jul 26, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@elwayman02
Copy link
Owner

The test support util we created for did-intersect doesn't have a way to restore the mock after a test: https://github.com/elwayman02/ember-scroll-modifiers/blob/master/addon-test-support/did-intersect-mock.js

We should export a method that makes it easy to clean up after the tests and avoid leaking state.

We do something similar here: https://github.com/elwayman02/ember-scroll-modifiers/blob/master/addon-test-support/scroll-into-view-mock.js#L24

cc: @ygongdev

@elwayman02 elwayman02 added enhancement New feature or request help wanted Extra attention is needed labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant