Hover bounds caching is messing with some clients

[mattiasdrp]

Thank you for the bug report

• I am using the latest version of lsp-mode related packages.
• I checked FAQ and Troubleshooting sections
• You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Bug description

As you can see in the following video, this piece of code in lsp-eldoc-function is messing with the lsp-ocaml client

  (if (and lsp--hover-saved-bounds
           (lsp--point-in-bounds-p lsp--hover-saved-bounds))
      lsp--eldoc-saved-message

Enregistrement.d.ecran_20250402_153634.webm

When the point is on struct, the saved bounds includes the function in the module and the hover is not computed resulting in a faulty returned type.

Steps to reproduce

• Start emacs with lsp-start-plain.el
• Register the ocaml-lsp-client

  (lsp-register-client
   (make-lsp-client
    :new-connection (lsp-stdio-connection
                     '("opam" "exec" "--" "ocamllsp"))
    :major-modes '(caml-mode tuareg-mode)
    :server-id 'ocaml-lsp-server))

• Install the ocaml-lsp-server
  • Install opam: https://opam.ocaml.org/doc/Install.html
  • opam install ocaml-lsp-server
• Create any OCaml file with

  let a = 3
  
  module A = struct
    let f a b c d e f = a + b + c + d + e + f
  end

• Hover over f (int -> int -> int -> int -> int -> int -> int)
• Hover over struct (sig)
• Hover back to f (previous type sig is displayed)
• Hover over a (int)
• Hover back to f (int -> int -> int -> int -> int -> int -> int)

Expected behavior

When hover over a value inside a module the type of the value should be displayed, not the type of the enclosing module.

Which Language Server did you use?

lsp-ocaml

OS

Linux

Error callstack

Anything else?

No response

[mattiasdrp]

One simple solution could be to add a custom value that allows to not cache the hover bounds.