From 80afa502992e2ff11d04a05ee1b3eb13b49a5d8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Codru=C8=9B=20Constantin=20Gu=C8=99oi?= Date: Sun, 11 Sep 2022 17:58:35 +0100 Subject: [PATCH 1/2] Fix emacs native compilation warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To reproduce, have emacs built with native compilation and notice the compilation logs. You can then open the offending file and run `M-x emacs-lisp-native-compile-and-load` before and after the changes to see the warning is removed. ``` ■ Warning (comp): lsp-treemacs.el:652:2: Warning: docstring wider than 80 characters ■ Warning (comp): lsp-treemacs.el:982:2: Warning: docstring wider than 80 characters ■ Warning (comp): lsp-treemacs.el:992:2: Warning: docstring wider than 80 characters ``` --- lsp-treemacs.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lsp-treemacs.el b/lsp-treemacs.el index 98eec7f..44e3630 100644 --- a/lsp-treemacs.el +++ b/lsp-treemacs.el @@ -650,7 +650,8 @@ will be rendered an empty line between them." ;;;###autoload (define-minor-mode lsp-treemacs-sync-mode - "Global minor mode for synchronizing lsp-mode workspace folders and treemacs projects." + "Global minor mode for synchronizing lsp-mode workspace folders +and treemacs projects." :init-value nil :group 'lsp-treemacs :global t @@ -981,7 +982,8 @@ depending on if a custom mode line is detected." ;;;###autoload (defun lsp-treemacs-references (arg) "Show the references for the symbol at point. -With a prefix argument, select the new window and expand the tree of references automatically." +With a prefix argument, select the new window and expand the tree +of references automatically." (interactive "P") (lsp-treemacs--do-search "textDocument/references" `(:context (:includeDeclaration t) ,@(lsp--text-document-position-params)) @@ -991,7 +993,8 @@ With a prefix argument, select the new window and expand the tree of references ;;;###autoload (defun lsp-treemacs-implementations (arg) "Show the implementations for the symbol at point. -With a prefix argument, select the new window expand the tree of implementations automatically." +With a prefix argument, select the new window expand the tree of +implementations automatically." (interactive "P") (lsp-treemacs--do-search "textDocument/implementation" (lsp--text-document-position-params) From f8443cdc12374d52680203db9de4ffdb58260273 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Codru=C8=9B=20Constantin=20Gu=C8=99oi?= Date: Sun, 11 Sep 2022 18:00:56 +0100 Subject: [PATCH 2/2] Fix eask warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ``` Unmatched website URL ’https://github.com/emacs-lsp/lsp-treemacs’; add (website-url "https://github.com/emacs-lsp/lsp-treemacs") to Eask-file Unmatched keyword ’languages’; add (keywords ... "languages") to Eask-file or consider removing it ``` --- Eask | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Eask b/Eask index 68b05e5..8f325c3 100644 --- a/Eask +++ b/Eask @@ -9,6 +9,9 @@ (source "gnu") (source "melpa") +(website-url "https://github.com/emacs-lsp/lsp-treemacs") +(keywords "languages") + (depends-on "emacs" "26.1") (depends-on "dash") (depends-on "f")