Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codesage-large-v2 #2090

Merged

Conversation

Aradhye2002
Copy link
Contributor

@Aradhye2002 Aradhye2002 commented Feb 18, 2025

mteb/models/codesage_models.py

Fixes #2020

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Testing

  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

Adding a model checklist

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Aradhye2002. It seems like there are still a few things in the checklist missing notably the missing import of the model, means that it is not discoverable using mteb.get_model(name)

@KennethEnevoldsen KennethEnevoldsen requested review from KennethEnevoldsen and removed request for KennethEnevoldsen February 19, 2025 14:45
@Aradhye2002
Copy link
Contributor Author

Thank you @KennethEnevoldsen, for the suggestions! I'll try my best to resolve the comments.

Copy link
Collaborator

@Samoed Samoed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add small and medium versions too?

@Aradhye2002
Copy link
Contributor Author

Can you add small and medium versions too?

Done

@Samoed
Copy link
Collaborator

Samoed commented Feb 20, 2025

Can you format your code?

@Aradhye2002
Copy link
Contributor Author

Can you format your code?

Done.

@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) February 20, 2025 11:48
@KennethEnevoldsen KennethEnevoldsen merged commit c052bbb into embeddings-benchmark:main Feb 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add https://huggingface.co/codesage/codesage-large-v2
3 participants