-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting enableTypeScriptTransform
to true breaks imports in .gjs tests
#228
Comments
enableTypeScriptTransform
to true breaks imports in .gjs tests
Thanks for reporting (and provided a repro repo), I'll look in to this, as I believe this may be the issue I'm seeing in a work-related project! |
So far, I've noticed that the issue reproduces only in classic (broccoli-only) mode -- |
@NullVoxPopuli Is there a workaround we could apply, e.g. switching to the above mentioned bundlers? |
right now the only work around I know of is to use v3 of template-imports. I have a hunch the babel config we have with ember-cli-babel may not be playing well with v4 of template-imports. Sorry it took so long to reply, this week's been nuts |
Seems that the issue is resolved now with the latest release of babel-plugin-ember-template-compilation after this change emberjs/babel-plugin-ember-template-compilation#34 |
Confirmed! |
I'm trying to add TS declarations to our V2 addon and to modify the
test-app
so that it properly consumes those declarations. The initial state of the repository was as follows:I then followed this instruction to add declaration files to the addon.
The problem is when I add TS-related dependencies to the
test-app
(all source files extensions are preserved) and set'ember-cli-babel': { enableTypeScriptTransform: true },
inember-cli-build.js
, the tests start failing with a very generic error "Could not find module<addon-name>
imported fromtest-app/tests/integration/helpers/<gjs-test>
". Here's the PR which reproduces the error, this is the exact test output.Note that without setting
'ember-cli-babel': { enableTypeScriptTransform: true },
the tests succeed. Please also note thatember-cli-typescript
is omitted.Am I missing some piece of configuration?
PS: This is the difference in the output tree before and after setting
enableTypeScriptTransform
:The text was updated successfully, but these errors were encountered: