update tests

Author: lifeart

src/template-linter.ts

@@ -144,22 +144,11 @@ export default class TemplateLinter {
       });
     }
   }
-  async lint(textDocument: TextDocument): Promise<Diagnostic[] | undefined> {
-    if (this._isEnabled === false) {
-      return;
-    }
-
-    const cwd = process.cwd();
-    const project = this.getProjectForDocument(textDocument);
-
-    if (!project) {
-      return;
-    }
-
+  getSourcesForDocument(textDocument: TextDocument, project: Project): string[] {
     const linterMeta = project.dependencyMap.get('ember-template-lint');
 
     if (!linterMeta) {
-      return;
+      return [];
     }
 
     let sources = [];
@@ -176,9 +165,26 @@ export default class TemplateLinter {
 
       sources = this.sourcesForDocument(textDocument, linterVersion);
     } catch (e) {
+      return [];
+    }
+
+    return sources;
+  }
+  async lint(textDocument: TextDocument): Promise<Diagnostic[] | undefined> {
+    if (this._isEnabled === false) {
+      return [];
+    }
+
+    const cwd = process.cwd();
+
+    const project = this.getProjectForDocument(textDocument);
+
+    if (!project) {
       return;
     }
 
+    const sources = this.getSourcesForDocument(textDocument, project);
+
     if (!sources.length) {
       return;
     }

test/template-linter-test.ts

@@ -1,59 +1,122 @@
-import * as semver from 'semver';
-
 import TemplateLinter from '../src/template-linter';
-import { type Server } from '../src';
-import { TextDocument } from 'vscode-languageserver-textdocument';
+import { type Project, type Server } from '../src';
+import { type TextDocument } from 'vscode-languageserver-textdocument';
 
-describe('template-linter', function () {
-  describe('sourcesForDocument', function () {
-    const linter = new TemplateLinter({
-      options: {
-        type: 'node',
+function getLinterInstance(depName?: string, depVersion?: string): [TemplateLinter, Project] {
+  const linter = new TemplateLinter({
+    projectRoots: {
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
+      projectForUri(_url: string) {
+        return {
+          dependencyMap: new Map(depName ? [[depName, { package: { name: depName, version: depVersion } }]] : []),
+        } as Project;
       },
-    } as Server);
+    },
+    options: {
+      type: 'node',
+    },
+  } as Server);
 
+  return [linter, linter['server'].projectRoots.projectForUri('') as Project];
+}
+
+describe('template-linter', function () {
+  describe('sourcesForDocument', function () {
     it('supports empty template-lint version', function () {
+      const [linter, project] = getLinterInstance();
+
+      const doc: TextDocument = {
+        uri: 'test.gjs',
+        getText() {
+          return 'let a = 12;<template>1</template>';
+        },
+      } as TextDocument;
+
+      expect(linter.getSourcesForDocument(doc, project)).toEqual([]);
+    });
+    it('supports incorrect template-lint version [foo-bar]', function () {
+      const [linter, project] = getLinterInstance('ember-template-lint', 'foo-bar');
+
+      const doc: TextDocument = {
+        uri: 'test.gjs',
+        getText() {
+          return 'let a = 12;<template>1</template>';
+        },
+      } as TextDocument;
+
+      expect(linter.getSourcesForDocument(doc, project)).toEqual([doc.getText()]);
+    });
+    it('supports incorrect template-lint version [*]', function () {
+      const [linter, project] = getLinterInstance('ember-template-lint', '*');
+
       const doc: TextDocument = {
         uri: 'test.gjs',
         getText() {
           return 'let a = 12;<template>1</template>';
         },
       } as TextDocument;
 
-      expect(linter['sourcesForDocument'](doc, null)).toEqual(['let a = 12;<template>1</template>']);
+      expect(linter.getSourcesForDocument(doc, project)).toEqual([doc.getText()]);
     });
-    it('process gjs for template-lint v4 with ~', function () {
+    it('process gjs for template-lint v2 with', function () {
+      const [linter, project] = getLinterInstance('ember-template-lint', '2.0.0');
+
       const doc: TextDocument = {
         uri: 'test.gjs',
         getText() {
           return 'let a = 12;<template>1</template>';
         },
       } as TextDocument;
 
-      console.log(semver.parse('~4.3.1')); // should be counted as 4.3.1
-      expect(linter['sourcesForDocument'](doc, semver.parse('~4.3.1'))).toEqual(['                     1']);
+      expect(linter.getSourcesForDocument(doc, project)).toEqual(['                     1']);
     });
-    it('process gjs for template-lint v4 with ^', function () {
+    it('process gjs for template-lint v3 with', function () {
+      const [linter, project] = getLinterInstance('ember-template-lint', '3.3.1');
+
       const doc: TextDocument = {
         uri: 'test.gjs',
         getText() {
           return 'let a = 12;<template>1</template>';
         },
       } as TextDocument;
 
-      console.log(semver.parse('^4.3.1')); // should be counted as 4.3.1
-      expect(linter['sourcesForDocument'](doc, semver.parse('^4.3.1'))).toEqual(['                     1']);
+      expect(linter.getSourcesForDocument(doc, project)).toEqual(['                     1']);
     });
-    it('process gjs for template-lint v4 with strict dependency', function () {
+    it('process gjs for template-lint v4 with', function () {
+      const [linter, project] = getLinterInstance('ember-template-lint', '4.3.1');
+
+      const doc: TextDocument = {
+        uri: 'test.gjs',
+        getText() {
+          return 'let a = 12;<template>1</template>';
+        },
+      } as TextDocument;
+
+      expect(linter.getSourcesForDocument(doc, project)).toEqual(['                     1']);
+    });
+    it('skip gjs processing for template-lint v5', function () {
+      const [linter, project] = getLinterInstance('ember-template-lint', '5.0.0');
+
+      const doc: TextDocument = {
+        uri: 'test.gjs',
+        getText() {
+          return 'let a = 12;<template>1</template>';
+        },
+      } as TextDocument;
+
+      expect(linter.getSourcesForDocument(doc, project)).toEqual([doc.getText()]);
+    });
+    it('skip gjs processing for template-lint v6', function () {
+      const [linter, project] = getLinterInstance('ember-template-lint', '6.0.0');
+
       const doc: TextDocument = {
         uri: 'test.gjs',
         getText() {
           return 'let a = 12;<template>1</template>';
         },
       } as TextDocument;
 
-      console.log(semver.parse('4.3.1')); // should be counted as 4.3.1
-      expect(linter['sourcesForDocument'](doc, semver.parse('4.3.1'))).toEqual(['                     1']);
+      expect(linter.getSourcesForDocument(doc, project)).toEqual([doc.getText()]);
     });
   });
 });