Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to @glimmer/syntax latest #72

Draft
wants to merge 14 commits into
base: nvp/fix-ci
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 65 additions & 5 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ on:
schedule:
- cron: '0 6 * * 0' # weekly, on sundays

# --ignore-scripts is used everywhere here because
# we want manual control over the build.
# the pre* scripts (ran via exclusion of --ignore-scripts) are kept for local development
jobs:
lint:
name: Linting
Expand All @@ -23,9 +26,33 @@ jobs:
- uses: actions/setup-node@v4
with:
cache: 'pnpm'
- run: pnpm install
- run: pnpm install --ignore-scripts
- run: pnpm lint


# To simulate what would happen when we push a release
# out to consumers, we're only going to build once, and
# then download the copy of those assets in each test job.
#
# This allows us to test against various node versions without
# changing how we compile (since consumers will not be compiling this library)
build:
name: Build
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
- uses: actions/setup-node@v4
with:
cache: 'pnpm'
- run: pnpm install --ignore-scripts
- run: pnpm build
- uses: actions/upload-artifact@v4
with:
name: bulit-assets
path: dist

test:
name: Tests
runs-on: ubuntu-latest
Expand All @@ -41,7 +68,11 @@ jobs:
with:
cache: 'pnpm'
node-version: ${{ matrix.node }}
- run: pnpm install
- run: pnpm install --ignore-scripts
- uses: actions/download-artifact@v4
with:
name: bulit-assets
path: dist
- run: pnpm test

test_old:
Expand All @@ -58,12 +89,17 @@ jobs:
cache: 'pnpm'
node-version: 14
# lockfile format version 9 didn't exist with pnpm 7
- run: pnpm install --no-lockfile
# ignore scripts because
- run: pnpm install --no-lockfile --ignore-scripts
- uses: actions/download-artifact@v4
with:
name: bulit-assets
path: dist
- run: pnpm test


floating-test:
name: Floating dependencies
name: Floating dependencies and build
runs-on: ubuntu-latest

steps:
Expand All @@ -72,5 +108,29 @@ jobs:
- uses: actions/setup-node@v4
with:
cache: 'pnpm'
- run: pnpm install --no-lockfile
- run: pnpm install --no-lockfile
- run: pnpm test


min-glimmer-syntax:
name: Latest @glimmer/syntax
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
- uses: actions/setup-node@v4
with:
cache: 'pnpm'
- run: pnpm install --no-lockfile --ignore-scripts
- uses: actions/download-artifact@v4
with:
name: bulit-assets
path: dist
- run: pnpm update @glimmer/syntax@0.84.3
- run: npx y-which @glimmer/syntax
# We use jest directly, because we don't want `pretest` to run,
# because we don't need to compile again
# (and don't want to since we changed the @glimmer/syntax version
# and TS would fail)
- run: pnpm jest
15 changes: 7 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,20 @@
"author": "Edward Faulkner <edward@eaf4.com>",
"exports": {
".": {
"browser": "./src/plugin.js",
"default": "./src/node-main.js"
"browser": "./dist/src/plugin.js",
"default": "./dist/src/node-main.js"
},
"./browser": "./src/plugin.js",
"./node": "./src/node-main.js"
"./browser": "./dist/src/plugin.js",
"./node": "./dist/src/node-main.js"
},
"main": "src/node-main.js",
"main": "dist/src/node-main.js",
"files": [
"src/**/*.js",
"src/**/*.d.ts",
"src/**/*.js.map"
"dist"
],
"scripts": {
"build": "tsc",
"clean": "git clean -d -f -x src __tests__",
"clean": "git clean -d -f -x dist",
"lint": "eslint --cache --ext .ts .",
"prepare": "tsc",
"pretest": "tsc",
Expand Down
Loading
Loading