Skip to content

Commit 4c78037

Browse files
gitKrystangitKrystan
committed
saveRecord tests
1 parent e3b3bdf commit 4c78037

File tree

3 files changed

+295
-2
lines changed

3 files changed

+295
-2
lines changed

‎packages/legacy-compat/src/builders.ts

+3
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,6 @@ export type { FindRecordBuilderOptions, FindRecordRequestInput } from './builder
66

77
export { queryBuilder as query, queryRecordBuilder as queryRecord } from './builders/query';
88
export type { QueryBuilderOptions, QueryRecordRequestInput, QueryRequestInput } from './builders/query';
9+
10+
export { saveRecordBuilder as saveRecord } from './builders/save-record';
11+
export type { SaveRecordBuilderOptions, SaveRecordRequestInput } from './builders/save-record';

‎packages/legacy-compat/src/builders/save-record.ts

-2
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ export function saveRecordBuilder<T>(record: T, options: Record<string, unknown>
8585
/*
8686
8787
TODO:
88-
* [] test this
89-
* [] make sure nothing fails bc of willCommit change
9088
* [] cargo cult jsdoc setup from json-api/src/-private/builders/query.ts
9189
9290
*/

‎tests/main/tests/integration/legacy-compat/save-record-test.ts

+292
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,292 @@
1+
import { module, test } from 'qunit';
2+
3+
import { setupTest } from 'ember-qunit';
4+
5+
import type { CompatStore } from '@ember-data/legacy-compat';
6+
import type { SaveRecordBuilderOptions } from '@ember-data/legacy-compat/builders';
7+
import { saveRecord } from '@ember-data/legacy-compat/builders';
8+
import Model, { attr } from '@ember-data/model';
9+
import { recordIdentifierFor } from '@ember-data/store';
10+
11+
class Post extends Model {
12+
@attr declare name: string;
13+
}
14+
15+
module('Integration - legacy-compat/builders/saveRecord', function (hooks) {
16+
setupTest(hooks);
17+
18+
hooks.beforeEach(function () {
19+
this.owner.register('model:post', Post);
20+
});
21+
22+
module('createRecord', function () {
23+
test('basic payload', async function (assert) {
24+
this.owner.register(
25+
'adapter:application',
26+
class Adapter {
27+
createRecord() {
28+
assert.step('adapter-createRecord');
29+
return Promise.resolve({
30+
data: {
31+
id: '1',
32+
type: 'post',
33+
attributes: {
34+
name: 'Krystan rules, you drool',
35+
},
36+
},
37+
});
38+
}
39+
static create() {
40+
return new this();
41+
}
42+
}
43+
);
44+
45+
const store = this.owner.lookup('service:store') as CompatStore;
46+
const newPost = store.createRecord('post', { name: 'Krystan rules, you drool' });
47+
const { content: savedPost } = await store.request<Post>(saveRecord(newPost));
48+
49+
assert.strictEqual(savedPost.id, '1', 'post has correct id');
50+
assert.strictEqual(savedPost.name, 'Krystan rules, you drool', 'post has correct name');
51+
assert.verifySteps(['adapter-createRecord'], 'adapter-createRecord was called');
52+
});
53+
54+
test('saveRecord', function (assert) {
55+
const store = this.owner.lookup('service:store') as CompatStore;
56+
const newPost = store.createRecord('post', { name: 'Krystan rules, you drool' });
57+
const identifier = recordIdentifierFor(newPost);
58+
const result = saveRecord(newPost);
59+
assert.deepEqual(
60+
result,
61+
{
62+
op: 'createRecord',
63+
data: {
64+
record: identifier,
65+
options: {},
66+
},
67+
records: [identifier],
68+
cacheOptions: {},
69+
},
70+
`saveRecord works`
71+
);
72+
});
73+
74+
test('saveRecord with options', function (assert) {
75+
const options: Required<SaveRecordBuilderOptions> = {
76+
whatever: true,
77+
adapterOptions: {},
78+
};
79+
const store = this.owner.lookup('service:store') as CompatStore;
80+
const newPost = store.createRecord('post', { name: 'Krystan rules, you drool' });
81+
const identifier = recordIdentifierFor(newPost);
82+
const result = saveRecord(newPost, options);
83+
assert.deepEqual(
84+
result,
85+
{
86+
op: 'createRecord',
87+
data: {
88+
record: identifier,
89+
options: options,
90+
},
91+
records: [identifier],
92+
cacheOptions: {},
93+
},
94+
`saveRecord works`
95+
);
96+
});
97+
});
98+
99+
module('deleteRecord', function () {
100+
test('basic payload', async function (assert) {
101+
this.owner.register(
102+
'adapter:application',
103+
class Adapter {
104+
deleteRecord() {
105+
assert.step('adapter-deleteRecord');
106+
return Promise.resolve();
107+
}
108+
static create() {
109+
return new this();
110+
}
111+
}
112+
);
113+
114+
const store = this.owner.lookup('service:store') as CompatStore;
115+
const existingPost = store.push({
116+
data: {
117+
id: '1',
118+
type: 'post',
119+
attributes: {
120+
name: 'Krystan rules, you drool',
121+
},
122+
},
123+
}) as Post;
124+
existingPost.deleteRecord();
125+
const { content: savedPost } = await store.request<Post>(saveRecord(existingPost));
126+
127+
assert.strictEqual(savedPost.id, '1', 'post has correct id');
128+
assert.strictEqual(savedPost.name, 'Krystan rules, you drool', 'post has correct name');
129+
assert.true(savedPost.isDeleted, 'post isDeleted');
130+
assert.verifySteps(['adapter-deleteRecord'], 'adapter-deleteRecord was called');
131+
});
132+
133+
test('saveRecord', function (assert) {
134+
const store = this.owner.lookup('service:store') as CompatStore;
135+
const existingPost = store.push({
136+
data: {
137+
id: '1',
138+
type: 'post',
139+
attributes: {
140+
name: 'Krystan rules, you drool',
141+
},
142+
},
143+
}) as Post;
144+
existingPost.deleteRecord();
145+
const identifier = recordIdentifierFor(existingPost);
146+
const result = saveRecord(existingPost);
147+
assert.deepEqual(
148+
result,
149+
{
150+
op: 'deleteRecord',
151+
data: {
152+
record: identifier,
153+
options: {},
154+
},
155+
records: [identifier],
156+
cacheOptions: {},
157+
},
158+
`saveRecord works`
159+
);
160+
});
161+
162+
test('saveRecord with options', function (assert) {
163+
const options: Required<SaveRecordBuilderOptions> = {
164+
whatever: true,
165+
adapterOptions: {},
166+
};
167+
const store = this.owner.lookup('service:store') as CompatStore;
168+
const existingPost = store.push({
169+
data: {
170+
id: '1',
171+
type: 'post',
172+
attributes: {
173+
name: 'Krystan rules, you drool',
174+
},
175+
},
176+
}) as Post;
177+
existingPost.deleteRecord();
178+
const identifier = recordIdentifierFor(existingPost);
179+
const result = saveRecord(existingPost, options);
180+
assert.deepEqual(
181+
result,
182+
{
183+
op: 'deleteRecord',
184+
data: {
185+
record: identifier,
186+
options: options,
187+
},
188+
records: [identifier],
189+
cacheOptions: {},
190+
},
191+
`saveRecord works`
192+
);
193+
});
194+
});
195+
196+
module('updateRecord', function () {
197+
test('basic payload', async function (assert) {
198+
this.owner.register(
199+
'adapter:application',
200+
class Adapter {
201+
updateRecord() {
202+
assert.step('adapter-updateRecord');
203+
return Promise.resolve();
204+
}
205+
static create() {
206+
return new this();
207+
}
208+
}
209+
);
210+
211+
const store = this.owner.lookup('service:store') as CompatStore;
212+
const existingPost = store.push({
213+
data: {
214+
id: '1',
215+
type: 'post',
216+
attributes: {
217+
name: 'Krystan rules, you drool',
218+
},
219+
},
220+
}) as Post;
221+
existingPost.name = 'Chris drools, Krystan rules';
222+
const { content: savedPost } = await store.request<Post>(saveRecord(existingPost));
223+
224+
assert.strictEqual(savedPost.id, '1', 'post has correct id');
225+
assert.strictEqual(savedPost.name, 'Krystan rules, you drool', 'post has correct name');
226+
assert.true(savedPost.isDeleted, 'post isDeleted');
227+
assert.verifySteps(['adapter-updateRecord'], 'adapter-updateRecord was called');
228+
});
229+
230+
test('saveRecord', function (assert) {
231+
const store = this.owner.lookup('service:store') as CompatStore;
232+
const existingPost = store.push({
233+
data: {
234+
id: '1',
235+
type: 'post',
236+
attributes: {
237+
name: 'Krystan rules, you drool',
238+
},
239+
},
240+
}) as Post;
241+
existingPost.name = 'Chris drools, Krystan rules';
242+
const identifier = recordIdentifierFor(existingPost);
243+
const result = saveRecord(existingPost);
244+
assert.deepEqual(
245+
result,
246+
{
247+
op: 'updateRecord',
248+
data: {
249+
record: identifier,
250+
options: {},
251+
},
252+
records: [identifier],
253+
cacheOptions: {},
254+
},
255+
`saveRecord works`
256+
);
257+
});
258+
259+
test('saveRecord with options', function (assert) {
260+
const options: Required<SaveRecordBuilderOptions> = {
261+
whatever: true,
262+
adapterOptions: {},
263+
};
264+
const store = this.owner.lookup('service:store') as CompatStore;
265+
const existingPost = store.push({
266+
data: {
267+
id: '1',
268+
type: 'post',
269+
attributes: {
270+
name: 'Krystan rules, you drool',
271+
},
272+
},
273+
}) as Post;
274+
existingPost.name = 'Chris drools, Krystan rules';
275+
const identifier = recordIdentifierFor(existingPost);
276+
const result = saveRecord(existingPost, options);
277+
assert.deepEqual(
278+
result,
279+
{
280+
op: 'updateRecord',
281+
data: {
282+
record: identifier,
283+
options: options,
284+
},
285+
records: [identifier],
286+
cacheOptions: {},
287+
},
288+
`saveRecord works`
289+
);
290+
});
291+
});
292+
});

0 commit comments

Comments
 (0)