chore: update perf suite

Author: runspired

package.json

@@ -12,7 +12,7 @@
     "prepare": "export TURBO_FORCE=true; turbo run build:pkg; pnpm run prepare:types;",
     "prepare:types": "export TURBO_FORCE=true; tsc --build --force; turbo run build:glint;",
     "release": "./release/index.ts",
-    "build": "turbo _build --log-order=stream --filter=./packages/* --concurrency=10;",
+    "build": "turbo run build:pkg --log-order=stream --concurrency=10;",
     "sync": "pnpm --filter './packages/*' run --parallel --if-present sync",
     "build:docs": "mkdir -p packages/-ember-data/dist && cd ./docs-generator && node ./compile-docs.js",
     "lint:tests": "turbo --log-order=stream lint --filter=./tests/* --continue --concurrency=10",

packages/build-config/src/debugging.ts

@@ -111,3 +111,11 @@ export const LOG_INSTANCE_CACHE: boolean = false;
  * @public
  */
 export const LOG_METRIC_COUNTS: boolean = false;
+/**
+ * Helps when debugging causes of a change notification
+ * when processing an update to a hasMany relationship.
+ *
+ * @property {boolean} DEBUG_RELATIONSHIP_NOTIFICATIONS
+ * @public
+ */
+export const DEBUG_RELATIONSHIP_NOTIFICATIONS: boolean = false;

tests/docs/fixtures/expected.js

@@ -606,6 +606,7 @@ module.exports = {
     '(public) @warp-drive/build-config/debugging DebugLogging#LOG_PAYLOADS',
     '(public) @warp-drive/build-config/debugging DebugLogging#LOG_REQUEST_STATUS',
     '(public) @warp-drive/build-config/debugging DebugLogging#LOG_REQUESTS',
+    '(public) @warp-drive/build-config/debugging DebugLogging#DEBUG_RELATIONSHIP_NOTIFICATIONS',
     '(public) @warp-drive/build-config/deprecations CurrentDeprecations#DEPRECATE_COMPUTED_CHAINS',
     '(public) @warp-drive/build-config/deprecations CurrentDeprecations#DEPRECATE_EMBER_INFLECTOR',
     '(public) @warp-drive/build-config/deprecations CurrentDeprecations#DEPRECATE_LEGACY_IMPORTS',

tests/performance/app/routes/update-with-same-state-m2m.js

@@ -1,17 +1,25 @@
+/* eslint-disable no-console */
+/* eslint-disable no-undef */
 import Route from '@ember/routing/route';
 import { inject as service } from '@ember/service';
 
-const REMOVAL_COUNT = 10;
+const DEBUG = false;
 
 export default Route.extend({
   store: service(),
 
   async model() {
+    DEBUG && console.groupCollapsed('test-setup');
     performance.mark('start-data-generation');
 
     const initialPayload = await fetch('./fixtures/big-many-to-many.json').then((r) => r.json());
     const initialPayload2 = structuredClone(initialPayload);
     const payloadWithRemoval = await fetch('./fixtures/big-many-to-many-with-removal.json').then((r) => r.json());
+    // our relationship has 10 * number of colors generated members,
+    // so this keeps us in-sync with the fixture generation
+    const REMOVAL_COUNT =
+      initialPayload.data[0].relationships.colors.data.length -
+      payloadWithRemoval.data[0].relationships.colors.data.length;
 
     performance.mark('start-push-initial-payload');
     this.store.push(initialPayload);
@@ -27,24 +35,68 @@ export default Route.extend({
     performance.mark('start-relationship-materialization');
     const seen = new Set();
     peekedCars.forEach((car) => iterateCar(car, seen));
+    seen.clear();
     const removedColors = [];
 
+    DEBUG && console.groupEnd();
+    DEBUG && console.log(structuredClone(getWarpDriveMetricCounts()));
+
     performance.mark('start-local-removal');
+    console.groupCollapsed('start-local-removal');
     for (const car of peekedCars) {
       const colors = car.colors;
       removedColors.push(colors.splice(0, REMOVAL_COUNT));
     }
+    peekedCars.forEach((car) => iterateCar(car, seen));
+    seen.clear();
+
+    DEBUG && console.groupEnd();
+    DEBUG && console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-push-minus-one-payload');
+    DEBUG && console.groupCollapsed('start-push-minus-one-payload');
+
     this.store.push(payloadWithRemoval);
+    DEBUG && console.groupEnd();
+    DEBUG && console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-local-addition');
-    peekedCars.forEach((car, index) => {
-      car.colors = removedColors[index].concat(car.colors);
-    });
+    DEBUG && console.groupCollapsed('start-local-addition');
+    // note, due to their position, the cars relationship on 50% of
+    // colors will end up reversed, causing us to generate a notification.
+    // this is because when we initially remove the colors from cars,
+    // we remove the car from wherever it occurs. When we re-add, that
+    // counts as re-adding "to the end" of the relationship since the
+    // removal was previously committed.
+    // To not generate a notification in this benchmark, the API response
+    // would need to account for the natural re-ordering of cars in the colors
+    // relationship.
+    //
+    // colors.cars = [1, 2, 3]
+    // cars.colors = [1, 2, 3]
+    // remove color 1 from cars.colors
+    // colors.cars = [2, 3]
+    // cars.colors = [2, 3]
+    // now add color-1 back to cars.colors at the front
+    // cars.colors = [1, 2, 3]
+    // colors.cars = [2, 3, 1] // notice order change
+    // but our payload will be [1, 2, 3] so we will generate a notification
+    // for colors.cars (we should not generate one for cars.colors)
+    for (let i = 0; i < peekedCars.length; i++) {
+      const car = peekedCars[i];
+      car.colors = removedColors[i].concat(car.colors);
+    }
+    peekedCars.forEach((car) => iterateCar(car, seen));
+    seen.clear();
+
+    DEBUG && console.groupEnd();
+    DEBUG && console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-push-plus-one-payload');
+    DEBUG && console.groupCollapsed('start-push-plus-one-payload');
     this.store.push(initialPayload2);
+    DEBUG && console.groupEnd();
+    DEBUG && console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('end-push-plus-one-payload');
   },

tests/performance/ember-cli-build.js

@@ -14,6 +14,7 @@ module.exports = async function (defaults) {
       // LOG_NOTIFICATIONS: true,
       // LOG_INSTANCE_CACHE: true,
       // LOG_METRIC_COUNTS: true,
+      // DEBUG_RELATIONSHIP_NOTIFICATIONS: true,
     },
   });
 

tests/performance/fixtures/index.js

@@ -28,24 +28,24 @@ const createParentRecords = require('./create-parent-records');
 const { createComplexPayload: createComplexRecordsPayload } = require('./create-complex-payload.ts');
 
 async function main() {
-  const initialChildrenPayload = createParentPayload(19600);
-  write('add-children-initial', initialChildrenPayload);
-  write('add-children-final', createParentPayload(20000));
-  const payloadWithRemoval = structuredClone(initialChildrenPayload);
-  payloadWithRemoval.data.relationships.children.data.splice(0, 19000);
-  payloadWithRemoval.included.splice(0, 19000);
-  write('add-children-with-removal', payloadWithRemoval);
+  // const initialChildrenPayload = createParentPayload(19600);
+  // write('add-children-initial', initialChildrenPayload);
+  // write('add-children-final', createParentPayload(20000));
+  // const payloadWithRemoval = structuredClone(initialChildrenPayload);
+  // payloadWithRemoval.data.relationships.children.data.splice(0, 19000);
+  // payloadWithRemoval.included.splice(0, 19000);
+  // write('add-children-with-removal', payloadWithRemoval);
 
-  write('destroy', createParentPayload(500, 50));
-  write('relationship-materialization-simple', createCarsPayload(10000));
-  write('relationship-materialization-complex', createParentRecords(200, 10, 20));
-  write('unload', createParentPayload(500, 50));
-  write('unload-all', createParentRecords(1000, 5, 10));
-  write('unused-relationships', createParentPayload(500, 50));
-  write('example-car', createCarsPayload(1));
-  write('example-parent', createParentPayload(2, 2));
-  write('basic-record-materialization', createParentRecords(10000, 2, 3));
-  write('complex-record-materialization', await createComplexRecordsPayload(400));
+  // write('destroy', createParentPayload(500, 50));
+  // write('relationship-materialization-simple', createCarsPayload(10000));
+  // write('relationship-materialization-complex', createParentRecords(200, 10, 20));
+  // write('unload', createParentPayload(500, 50));
+  // write('unload-all', createParentRecords(1000, 5, 10));
+  // write('unused-relationships', createParentPayload(500, 50));
+  // write('example-car', createCarsPayload(1));
+  // write('example-parent', createParentPayload(2, 2));
+  // write('basic-record-materialization', createParentRecords(10000, 2, 3));
+  // write('complex-record-materialization', await createComplexRecordsPayload(400));
 
   const initialBigM2M = createCarsPayload(100, 100);
   write('big-many-to-many', initialBigM2M);

tests/performance/vite.config.mjs

@@ -59,6 +59,7 @@ export default defineConfig({
         negate_iife: false,
         sequences: 30,
         defaults: true,
+        drop_debugger: false,
         arguments: false,
         keep_fargs: false,
         toplevel: false,