stash stuffs

Author: runspired

packages/graph/src/-private/-diff.ts

@@ -164,12 +164,17 @@ function _compare<T>(
   const prevLength = prevState.length;
   const iterationLength = Math.max(finalLength, prevLength);
   const equalLength = finalLength === prevLength;
-  let changed: boolean = finalSet.size !== prevSet.size;
-  let remoteOrderChanged = false;
+  let remoteOrderChanged = finalSet.size !== prevSet.size;
+  let changed: boolean = priorLocalState ? finalSet.size !== priorLocalState.length : remoteOrderChanged;
   const added = new Set<T>();
   const removed = new Set<T>();
   const priorLocalLength = priorLocalState?.length ?? 0;
 
+  changed &&
+    console.log(
+      `changed because ${priorLocalState ? 'finalSet.size !== priorLocalState.length' : 'finalSet.size !== prevSet.size'}`
+    );
+
   for (let i = 0; i < iterationLength; i++) {
     let member: T | undefined;
 
@@ -181,6 +186,7 @@ function _compare<T>(
         if (i < priorLocalLength) {
           const priorLocalMember = priorLocalState![i];
           if (priorLocalMember !== member) {
+            !changed && console.log(`changed because priorLocalMember !== member && !prevSet.has(member)`);
             changed = true;
           }
         }
@@ -214,9 +220,11 @@ function _compare<T>(
           if (i < priorLocalLength) {
             const priorLocalMember = priorLocalState![i];
             if (priorLocalMember !== member) {
+              !changed && console.log(`changed because priorLocalMember !== member && member !== prevMember`);
               changed = true;
             }
           } else {
+            !changed && console.log(`changed because priorLocalMember !== member && index >= priorLocalLength`);
             changed = true;
           }
         }
@@ -236,6 +244,7 @@ function _compare<T>(
       }
 
       if (!finalSet.has(prevMember)) {
+        !changed && console.log(`changed because !finalSet.has(prevMember)`);
         changed = true;
         removed.add(prevMember);
         onDel(prevMember);

packages/graph/src/-private/operations/replace-related-records.ts

@@ -75,6 +75,7 @@ export default function replaceRelatedRecords(graph: Graph, op: ReplaceRelatedRe
   }
 }
 
+// FIXME: Add metric count for number of calls to this
 function replaceRelatedRecordsLocal(graph: Graph, op: ReplaceRelatedRecordsOperation, isRemote: boolean) {
   const identifiers = op.value;
   const relationship = graph.get(op.record, op.field);
@@ -160,6 +161,7 @@ function replaceRelatedRecordsLocal(graph: Graph, op: ReplaceRelatedRecordsOpera
   }
 }
 
+// FIXME: Add metric count for number of calls to this
 function replaceRelatedRecordsRemote(graph: Graph, op: ReplaceRelatedRecordsOperation, isRemote: boolean) {
   const identifiers = op.value;
   const relationship = graph.get(op.record, op.field);

tests/performance/app/routes/update-with-same-state-m2m.js

@@ -1,12 +1,16 @@
+// FIXME: Don't merge disables
+/* eslint-disable no-console */
+/* eslint-disable no-undef */
 import Route from '@ember/routing/route';
 import { inject as service } from '@ember/service';
 
-const REMOVAL_COUNT = 10;
+const REMOVAL_COUNT = 1;
 
 export default Route.extend({
   store: service(),
 
   async model() {
+    console.groupCollapsed('test-setup');
     performance.mark('start-data-generation');
 
     const initialPayload = await fetch('./fixtures/big-many-to-many.json').then((r) => r.json());
@@ -27,24 +31,46 @@ export default Route.extend({
     performance.mark('start-relationship-materialization');
     const seen = new Set();
     peekedCars.forEach((car) => iterateCar(car, seen));
+    seen.clear();
     const removedColors = [];
 
+    console.groupEnd();
+    console.log(structuredClone(getWarpDriveMetricCounts()));
+
     performance.mark('start-local-removal');
+    console.groupCollapsed('start-local-removal');
     for (const car of peekedCars) {
       const colors = car.colors;
       removedColors.push(colors.splice(0, REMOVAL_COUNT));
+      iterateCar(car, seen);
     }
+    seen.clear();
+
+    console.groupEnd();
+    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-push-minus-one-payload');
+    console.groupCollapsed('start-push-minus-one-payload');
     this.store.push(payloadWithRemoval);
+    console.groupEnd();
+    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-local-addition');
+    console.groupCollapsed('start-local-addition');
     peekedCars.forEach((car, index) => {
       car.colors = removedColors[index].concat(car.colors);
+      iterateCar(car, seen);
     });
+    seen.clear();
+
+    console.groupEnd();
+    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-push-plus-one-payload');
+    console.groupCollapsed('start-push-plus-one-payload');
     this.store.push(initialPayload2);
+    console.groupEnd();
+    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('end-push-plus-one-payload');
   },

tests/performance/ember-cli-build.js

@@ -11,9 +11,9 @@ module.exports = async function (defaults) {
   setConfig(app, __dirname, {
     compatWith: '99',
     debug: {
-      // LOG_NOTIFICATIONS: true,
+      LOG_NOTIFICATIONS: true,
       // LOG_INSTANCE_CACHE: true,
-      // LOG_METRIC_COUNTS: true,
+      LOG_METRIC_COUNTS: true,
     },
   });
 

tests/performance/fixtures/generated/big-many-to-many-with-removal.json.br

@@ -28,26 +28,26 @@ const createParentRecords = require('./create-parent-records');
 const { createComplexPayload: createComplexRecordsPayload } = require('./create-complex-payload.ts');
 
 async function main() {
-  const initialChildrenPayload = createParentPayload(19600);
-  write('add-children-initial', initialChildrenPayload);
-  write('add-children-final', createParentPayload(20000));
-  const payloadWithRemoval = structuredClone(initialChildrenPayload);
-  payloadWithRemoval.data.relationships.children.data.splice(0, 19000);
-  payloadWithRemoval.included.splice(0, 19000);
-  write('add-children-with-removal', payloadWithRemoval);
+  // const initialChildrenPayload = createParentPayload(19600);
+  // write('add-children-initial', initialChildrenPayload);
+  // write('add-children-final', createParentPayload(20000));
+  // const payloadWithRemoval = structuredClone(initialChildrenPayload);
+  // payloadWithRemoval.data.relationships.children.data.splice(0, 19000);
+  // payloadWithRemoval.included.splice(0, 19000);
+  // write('add-children-with-removal', payloadWithRemoval);
 
-  write('destroy', createParentPayload(500, 50));
-  write('relationship-materialization-simple', createCarsPayload(10000));
-  write('relationship-materialization-complex', createParentRecords(200, 10, 20));
-  write('unload', createParentPayload(500, 50));
-  write('unload-all', createParentRecords(1000, 5, 10));
-  write('unused-relationships', createParentPayload(500, 50));
-  write('example-car', createCarsPayload(1));
-  write('example-parent', createParentPayload(2, 2));
-  write('basic-record-materialization', createParentRecords(10000, 2, 3));
-  write('complex-record-materialization', await createComplexRecordsPayload(400));
+  // write('destroy', createParentPayload(500, 50));
+  // write('relationship-materialization-simple', createCarsPayload(10000));
+  // write('relationship-materialization-complex', createParentRecords(200, 10, 20));
+  // write('unload', createParentPayload(500, 50));
+  // write('unload-all', createParentRecords(1000, 5, 10));
+  // write('unused-relationships', createParentPayload(500, 50));
+  // write('example-car', createCarsPayload(1));
+  // write('example-parent', createParentPayload(2, 2));
+  // write('basic-record-materialization', createParentRecords(10000, 2, 3));
+  // write('complex-record-materialization', await createComplexRecordsPayload(400));
 
-  const initialBigM2M = createCarsPayload(100, 100);
+  const initialBigM2M = createCarsPayload(2, 2);
   write('big-many-to-many', initialBigM2M);
   write('big-many-to-many-with-removal', deleteHalfTheColors(initialBigM2M));
 }