Tidy up

Author: gitKrystan

tests/performance/app/routes/update-with-same-state-m2m.js

@@ -1,6 +1,3 @@
-// FIXME: Don't merge disables
-/* eslint-disable no-console */
-/* eslint-disable no-undef */
 import Route from '@ember/routing/route';
 import { inject as service } from '@ember/service';
 
@@ -10,7 +7,6 @@ export default Route.extend({
   store: service(),
 
   async model() {
-    console.groupCollapsed('test-setup');
     performance.mark('start-data-generation');
 
     const initialPayload = await fetch('./fixtures/big-many-to-many.json').then((r) => r.json());
@@ -33,39 +29,22 @@ export default Route.extend({
     peekedCars.forEach((car) => iterateCar(car, seen));
     const removedColors = [];
 
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
-
     performance.mark('start-local-removal');
-    console.groupCollapsed('start-local-removal');
     for (const car of peekedCars) {
       const colors = car.colors;
       removedColors.push(colors.splice(0, REMOVAL_COUNT));
     }
 
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
-
     performance.mark('start-push-minus-one-payload');
-    console.groupCollapsed('start-push-minus-one-payload');
     this.store.push(payloadWithRemoval);
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-local-addition');
-    console.groupCollapsed('start-local-addition');
     peekedCars.forEach((car, index) => {
       car.colors = removedColors[index].concat(car.colors);
     });
 
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
-
     performance.mark('start-push-plus-one-payload');
-    console.groupCollapsed('start-push-plus-one-payload');
     this.store.push(initialPayload2);
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('end-push-plus-one-payload');
   },

tests/performance/app/routes/update-with-same-state.js

@@ -5,15 +5,11 @@ export default Route.extend({
   store: service(),
 
   async model() {
-    console.groupCollapsed('test-setup');
     performance.mark('start-data-generation');
 
     const initialPayload = await fetch('./fixtures/add-children-initial.json').then((r) => r.json());
     const initialPayload2 = structuredClone(initialPayload);
-
-    const payloadWithRemoval = structuredClone(initialPayload);
-    payloadWithRemoval.data.relationships.children.data.splice(0, 19000);
-    payloadWithRemoval.included.splice(0, 19000);
+    const payloadWithRemoval = await fetch('./fixtures/add-children-with-removal.json').then((r) => r.json());
 
     performance.mark('start-push-initial-payload');
     this.store.push(initialPayload);
@@ -32,56 +28,29 @@ export default Route.extend({
     const parent = peekedParents[0];
     const children = await parent.children;
 
-    await logChildren(parent);
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
-
     performance.mark('start-local-removal');
-    console.groupCollapsed('start-local-removal');
     const removedChildren = children.splice(0, 19000);
-    await logChildren(parent);
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-push-minus-one-payload');
-    console.groupCollapsed('start-push-minus-one-payload');
     this.store.push(payloadWithRemoval);
-    await logChildren(parent);
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-local-addition');
-    console.groupCollapsed('start-local-addition');
     parent.children = removedChildren.concat(children);
-    await logChildren(parent);
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('start-push-plus-one-payload');
-    console.groupCollapsed('start-push-plus-one-payload');
     this.store.push(initialPayload2);
-    await logChildren(parent);
-    console.groupEnd();
-    console.log(structuredClone(getWarpDriveMetricCounts()));
 
     performance.mark('end-push-plus-one-payload');
   },
 });
 
-async function logChildren(parent) {
-  const children = await parent.children;
-  console.log(
-    `children is an array of length ${children.length} of ids ${children.at(0).id}..${children.at(children.length - 1).id}`
-  );
-}
-
 function iterateChild(record, seen) {
   if (seen.has(record)) {
     return;
   }
   seen.add(record);
 
-  record.parent.get('name');
+  record.parent;
 }
 
 function iterateParent(record, seen) {

tests/performance/fixtures/generated/add-children-with-removal.json.br

@@ -1,9 +1,3 @@
-/*
-
-Run this file with `bun run ./fixtures/index.js` to generate the fixtures for the performance benchmarks.
-
-*/
-
 const fs = require('fs');
 const zlib = require('zlib');
 
@@ -34,8 +28,14 @@ const createParentRecords = require('./create-parent-records');
 const { createComplexPayload: createComplexRecordsPayload } = require('./create-complex-payload.ts');
 
 async function main() {
-  write('add-children-initial', createParentPayload(19600));
+  const initialChildrenPayload = createParentPayload(19600);
+  write('add-children-initial', initialChildrenPayload);
   write('add-children-final', createParentPayload(20000));
+  const payloadWithRemoval = structuredClone(initialChildrenPayload);
+  payloadWithRemoval.data.relationships.children.data.splice(0, 19000);
+  payloadWithRemoval.included.splice(0, 19000);
+  write('add-children-with-removal', payloadWithRemoval);
+
   write('destroy', createParentPayload(500, 50));
   write('relationship-materialization-simple', createCarsPayload(10000));
   write('relationship-materialization-complex', createParentRecords(200, 10, 20));

tests/performance/fixtures/index.js

@@ -17,7 +17,8 @@
   "scripts": {
     "build": "vite build",
     "start": "bun ./server/index.ts",
-    "lint": "eslint . --quiet --cache --cache-strategy=content"
+    "lint": "eslint . --quiet --cache --cache-strategy=content",
+    "fixtures": "bun run ./fixtures/index.js"
   },
   "devDependencies": {
     "@babel/core": "^7.26.9",