make setup more robust

runspired · runspired · commit f8ff2e69ee25 · 2025-03-22T22:49:55.000-07:00
diff --git a/.github/workflows/canary-docs-preview.yml b/.github/workflows/canary-docs-preview.yml
@@ -30,7 +30,6 @@ jobs:
           restore-broccoli-cache: true
           jobs: 4
           parallel-build: true
-          with-cert: false
           install: true
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Install Docs Dependencies
diff --git a/docs-viewer/src/preview-docs.ts b/docs-viewer/src/preview-docs.ts
@@ -104,13 +104,15 @@ async function cloneRepo(details: ReturnType<typeof repoDetails>) {
 
   // if the clone fails for publicKey we try https
   if (exitCode !== 0) {
-    const reason = await new Response(proc.stderr).text();
+    const reason = await new Response(proc.stdout).text();
     if (reason.includes('publickey')) {
       log(`Cloning ${chalk.green(details.repoPath)} to ${chalk.green(relativePath)} using https`);
       const proc2 = Bun.spawn(['git', 'clone', details.httpsUrl, relativePath, '--depth=1'], {
         cwd: docsViewerRoot,
       });
       await proc2.exited;
+    } else {
+      throw new Error(reason);
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -104,13 +104,15 @@ async function cloneRepo(details: ReturnType<typeof repoDetails>) {`
`104`	`104`
`105`	`105`	`// if the clone fails for publicKey we try https`
`106`	`106`	`if (exitCode !== 0) {`
`107`		`- const reason = await new Response(proc.stderr).text();`
	`107`	`+ const reason = await new Response(proc.stdout).text();`
`108`	`108`	`if (reason.includes('publickey')) {`
`109`	`109`	log(`Cloning ${chalk.green(details.repoPath)} to ${chalk.green(relativePath)} using https`);
`110`	`110`	`const proc2 = Bun.spawn(['git', 'clone', details.httpsUrl, relativePath, '--depth=1'], {`
`111`	`111`	`cwd: docsViewerRoot,`
`112`	`112`	`});`
`113`	`113`	`await proc2.exited;`
	`114`	`+ } else {`
	`115`	`+ throw new Error(reason);`
`114`	`116`	`}`
`115`	`117`	`}`
`116`	`118`	`}`