Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Get a simple fastboot smoke test working #6531

Merged
merged 9 commits into from
Oct 2, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Sep 30, 2019

For #6431, #6103

Unfortunately, there was nothing like a real acceptance test in the repo, so I created one based on https://github.com/emberjs/data/blob/ac602c48d75f882657db6e0020e496401975818b/packages/-ember-data/tests/acceptance/relationships/has-many-test.js

Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit but otherwise looks great! The next step is to use ember-try to run this test app twice, once with jQuery and once without.

@runspired runspired added 🏷️ test This PR primarily adds tests for a feature CI labels Oct 2, 2019
@runspired runspired merged commit c45ea2a into emberjs:master Oct 2, 2019
@Gaurav0 Gaurav0 deleted the fastboot_test branch October 3, 2019 14:09
igorT pushed a commit that referenced this pull request Nov 4, 2019
* [TEST] Get a simple fastboot smoke test working

* Move fastboot test to its own package/app

* Add to CI

* yarn sync-dev

* yarn sync-dev

* fix nit

* Fix prettier
igorT pushed a commit that referenced this pull request Nov 6, 2019
* [TEST] Get a simple fastboot smoke test working

* Move fastboot test to its own package/app

* Add to CI

* yarn sync-dev

* yarn sync-dev

* fix nit

* Fix prettier
igorT pushed a commit that referenced this pull request Nov 6, 2019
* [TEST] Get a simple fastboot smoke test working

* Move fastboot test to its own package/app

* Add to CI

* yarn sync-dev

* yarn sync-dev

* fix nit

* Fix prettier
@runspired runspired added Infra/CI/DX and removed CI labels Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infra/CI/DX 🏷️ test This PR primarily adds tests for a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants