Fix trailing ? in URL of query builder
#9216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltazore
commented
Feb 1, 2024
| @@ -76,12 +76,14 @@ export function query( | |||
|
|
|||
| copyForwardUrlOptions(urlOptions, options); | |||
|
|
|||
| const url = buildBaseURL(urlOptions); | |||
| const url = new URL(buildBaseURL(urlOptions)); | |||
There was a problem hiding this comment.
@runspired please let me know if this is good approach?
The only downside I see - it most likely append host in it.
Also it creates new instance of URL, not sure how performant it is.
runspired
reviewed
Feb 9, 2024
| const headers = new Headers(); | ||
| headers.append('Accept', 'application/json;charset=utf-8'); | ||
|
|
||
| return { | ||
| url: `${url}?${buildQueryParams(query, options.urlParamsSettings)}`, |
There was a problem hiding this comment.
I think instead we should check if there is a query / check if buildQueryParams has output and use that to conditionally join with a ?
|
Ended up porting the tests into #9220 with a modified approach there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix trailing ? in built url for query builder across json-api/rest/active-record
Mirage have troubles recognizing URL with trailing
?I think other routers might have problems as well
Notes for the release