Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: request infra improvements #9220

Merged
merged 9 commits into from
Feb 11, 2024
Merged

feat: request infra improvements #9220

merged 9 commits into from
Feb 11, 2024

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Feb 9, 2024 •
edited
Loading

Various small improvements to the request infrastructure to improve DX

  • error titles now have Request.method and Response.type in them for filtering
  • buildBaseURL allows for more basic usage scenarios
  • the basic LifetimesService has a built-in mechanism for invalidation based on createRecord
  • empty query does not produce a trailing ? in the url (replaces Fix trailing ? in URL of query builder #9216)

@runspired runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ feat This PR introduces a new feature lts-4-12 Long Term LTS Maintenance labels Feb 9, 2024
@runspired runspired self-assigned this Feb 9, 2024
@runspired runspired merged commit 91b4275 into main Feb 11, 2024
19 of 20 checks passed
@runspired runspired deleted the runspired-update-infra branch February 11, 2024 04:29
@runspired runspired mentioned this pull request Feb 12, 2024
Closed
runspired added a commit that referenced this pull request Feb 13, 2024
@runspired
feat: request infra improvements (#9220)
4e6f327 
* chore: improve error message tracing

* update all the things

* fixup docs

* cleanup private access

* fix trailing ?

* fix lint

* fix arg ordering

* fix type

* fix more types
@runspired runspired mentioned this pull request Feb 13, 2024
Closed
@gitKrystan gitKrystan mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@runspired runspired

Labels
🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release 🏷️ feat This PR introduces a new feature lts-4-12 Long Term LTS Maintenance
Projects
EmberData
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@runspired