all the lint

emberjs · runspired · Mar 22, 2024 · Mar 19, 2024 · Mar 20, 2024 · Mar 20, 2024
commit 1a7a2f61e81cdb43f28a5947429843466bd0a036
diff --git a/package.json b/package.json
@@ -56,7 +56,7 @@
     "rimraf": "^5.0.5",
     "semver": "^7.5.4",
     "silent-error": "^1.1.1",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "url": "^0.11.3",
     "yuidocjs": "^0.10.2",
     "zlib": "1.0.5"

diff --git a/packages/-ember-data/package.json b/packages/-ember-data/package.json
@@ -67,7 +67,7 @@
     "ember-auto-import": "^2.7.0",
     "ember-cli-babel": "^8.2.0",
     "ember-inflector": "^4.0.2",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "pnpm-sync-dependencies-meta-injected": "0.0.10",
     "webpack": "^5.89.0"
   },

diff --git a/packages/active-record/package.json b/packages/active-record/package.json
@@ -107,7 +107,7 @@
     "ember-inflector": "^4.0.2",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0"
   },
   "ember": {

diff --git a/packages/adapter/package.json b/packages/adapter/package.json
@@ -124,7 +124,7 @@
     "ember-inflector": "^4.0.2",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0",
     "webpack": "^5.89.0"
   },

diff --git a/packages/core-types/package.json b/packages/core-types/package.json
@@ -67,7 +67,7 @@
     "@warp-drive/internal-config": "workspace:5.4.0-alpha.39",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0",
     "webpack": "^5.89.0"
   },

diff --git a/packages/diagnostic/package.json b/packages/diagnostic/package.json
@@ -117,7 +117,7 @@
     "@glimmer/component": "^1.1.2",
     "ember-cli-test-loader": "^3.1.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0"
   },
   "engines": {

diff --git a/packages/ember/package.json b/packages/ember/package.json
@@ -110,7 +110,7 @@
     "ember-template-imports": "^4.1.0",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0"
   },
   "engines": {

diff --git a/packages/graph/package.json b/packages/graph/package.json
@@ -93,7 +93,7 @@
     "@warp-drive/internal-config": "workspace:5.4.0-alpha.39",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0",
     "webpack": "^5.89.0"
   },

diff --git a/packages/graph/src/-private/-edge-definition.ts b/packages/graph/src/-private/-edge-definition.ts
@@ -376,7 +376,7 @@ export function upgradeDefinition(
     // we should only hit this in prod
     assert(`Expected a relationship schema for '${type}.${propertyName}', but no relationship schema was found.`, meta);
 
-    cache[type]![propertyName] = null;
+    cache[type][propertyName] = null;
     return null;
   }
   const definition = /*#__NOINLINE__*/ upgradeMeta(meta);

diff --git a/packages/graph/src/-private/graph.ts b/packages/graph/src/-private/graph.ts
@@ -269,7 +269,7 @@ export class Graph {
       // cleans up the graph but retains some nodes
       // to allow for rematerialization
       Object.keys(relationships).forEach((key) => {
-        const rel = relationships[key]!;
+        const rel = relationships[key];
         if (!rel) {
           return;
         }

diff --git a/packages/holodeck/package.json b/packages/holodeck/package.json
@@ -65,7 +65,7 @@
     "@warp-drive/core-types": "workspace:0.0.0-alpha.25",
     "@warp-drive/internal-config": "workspace:5.4.0-alpha.39",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0"
   },
   "type": "module",

diff --git a/packages/json-api/package.json b/packages/json-api/package.json
@@ -118,7 +118,7 @@
     "ember-inflector": "^4.0.2",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0",
     "webpack": "^5.89.0"
   },

diff --git a/packages/json-api/src/-private/cache.ts b/packages/json-api/src/-private/cache.ts
@@ -439,7 +439,7 @@ export default class JSONAPICache implements Cache {
       const rels = this.__graph.identifiers.get(identifier);
       if (rels) {
         Object.keys(rels).forEach((key) => {
-          const rel = rels[key]!;
+          const rel = rels[key];
           if (rel.definition.isImplicit) {
             return;
           } else {

diff --git a/packages/legacy-compat/package.json b/packages/legacy-compat/package.json
@@ -132,7 +132,7 @@
     "ember-inflector": "^4.0.2",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0"
   },
   "ember": {

diff --git a/packages/legacy-compat/src/index.ts b/packages/legacy-compat/src/index.ts
@@ -288,14 +288,14 @@ export function cleanup(this: Store) {
   upgradeStore(this);
   // enqueue destruction of any adapters/serializers we have created
   for (const adapterName in this._adapterCache) {
-    const adapter = this._adapterCache[adapterName]!;
+    const adapter = this._adapterCache[adapterName];
     if (typeof adapter.destroy === 'function') {
       adapter.destroy();
     }
   }
 
   for (const serializerName in this._serializerCache) {
-    const serializer = this._serializerCache[serializerName]!;
+    const serializer = this._serializerCache[serializerName];
     if (typeof serializer.destroy === 'function') {
       serializer.destroy();
     }

diff --git a/packages/model/package.json b/packages/model/package.json
@@ -147,7 +147,7 @@
     "ember-source": "~5.6.0",
     "expect-type": "^0.18.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0",
     "webpack": "^5.89.0"
   },

diff --git a/packages/model/src/-private/model.type-test.ts b/packages/model/src/-private/model.type-test.ts
@@ -123,16 +123,16 @@ expectTypeOf(
 
 expectTypeOf(user.hasMany('enemies')).toEqualTypeOf<HasManyReference<UnbrandedUser, 'enemies'>>();
 expectTypeOf(user.hasMany('enemies').___identifier.type).toEqualTypeOf<string>();
-expectTypeOf(user.hasMany('enemies').identifiers[0]!.type).toEqualTypeOf<string>();
+expectTypeOf(user.hasMany('enemies').identifiers[0].type).toEqualTypeOf<string>();
 expectTypeOf(user.hasMany('enemies').key).toEqualTypeOf<'enemies'>();
 expectTypeOf(user.hasMany('enemies').type).toEqualTypeOf<string>();
 expectTypeOf(user.hasMany('enemies').value()).toMatchTypeOf<UnbrandedUser[] | null>();
 
 expectTypeOf(branded.hasMany('enemies')).toEqualTypeOf<HasManyReference<BrandedUser, 'enemies'>>();
 expectTypeOf(branded.hasMany('enemies').___identifier.type).toEqualTypeOf<'user'>();
-expectTypeOf(branded.hasMany('enemies').identifiers[0]!.type).toEqualTypeOf<'user'>();
+expectTypeOf(branded.hasMany('enemies').identifiers[0].type).toEqualTypeOf<'user'>();
 expectTypeOf(branded.hasMany('enemies').___identifier.type).not.toEqualTypeOf<string>();
-expectTypeOf(branded.hasMany('enemies').identifiers[0]!.type).not.toEqualTypeOf<string>();
+expectTypeOf(branded.hasMany('enemies').identifiers[0].type).not.toEqualTypeOf<string>();
 expectTypeOf(branded.hasMany('enemies').key).toEqualTypeOf<'enemies'>();
 expectTypeOf(branded.hasMany('enemies').type).toEqualTypeOf<'user'>();
 expectTypeOf(branded.hasMany('enemies').value()).toMatchTypeOf<BrandedUser[] | null>();
diff --git a/packages/request-utils/package.json b/packages/request-utils/package.json
@@ -74,7 +74,7 @@
     "@warp-drive/internal-config": "workspace:5.4.0-alpha.39",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0"
   },
   "ember": {

diff --git a/packages/request/package.json b/packages/request/package.json
@@ -78,7 +78,7 @@
     "@warp-drive/internal-config": "workspace:5.4.0-alpha.39",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0"
   },
   "engines": {

diff --git a/packages/rest/package.json b/packages/rest/package.json
@@ -84,7 +84,7 @@
     "ember-inflector": "^4.0.2",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0"
   },
   "ember": {

diff --git a/packages/schema-record/package.json b/packages/schema-record/package.json
@@ -95,7 +95,7 @@
     "@warp-drive/internal-config": "workspace:5.4.0-alpha.39",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0",
     "webpack": "^5.89.0",
     "@ember/string": "^3.1.1"

diff --git a/packages/serializer/package.json b/packages/serializer/package.json
@@ -105,7 +105,7 @@
     "ember-inflector": "^4.0.2",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0",
     "webpack": "^5.89.0"
   },

diff --git a/packages/tracking/package.json b/packages/tracking/package.json
@@ -84,7 +84,7 @@
     "@warp-drive/internal-config": "workspace:5.4.0-alpha.39",
     "ember-source": "~5.6.0",
     "rollup": "^4.9.6",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "walk-sync": "^3.0.0"
   },
   "ember": {

diff --git a/packages/unpublished-test-infra/package.json b/packages/unpublished-test-infra/package.json
@@ -74,7 +74,7 @@
     "qunit": "^2.20.0",
     "semver": "^7.5.4",
     "testem": "^3.11.0",
-    "typescript": "^5.4.2",
+    "typescript": "^5.4.3",
     "webpack": "^5.89.0"
   },
   "dependenciesMeta": {