Don't set isDirty to true in diff callbacks

[gitKrystan]

Theoretically the diff function is smart enough for this to no longer be necessary. Reduces overnotification.

Description

Notes for the release

[github-actions]

Performance Report for b6d1cb8

Scenario - basic-record-materialization: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +8ms [1ms to 15ms] OR +0.56% [0.05% to 1.05%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [0ms to 0ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 1ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-1ms to 9ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [0ms to 7ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [0ms to 0ms]

Scenario - complex-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-1ms to 9ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [0ms to 1ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-2ms to 8ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-1ms to 2ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [0ms to 0ms]

Scenario - complex-record-materialization-with-relationship-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 5ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-1ms to 0ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-5ms to 5ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-field-access]
phase no difference [-2ms to 0ms]
☑️ Phase [start-field-access] => [start-relationship-access]
phase no difference [0ms to 0ms]
☑️ Phase [start-relationship-access] => [end-relationship-access]
phase no difference [0ms to 0ms]
☑️ Phase [end-relationship-access] => [Test End]
phase no difference [0ms to 0ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 2ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-1ms to 0ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-4ms to 1ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-1ms to 2ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - relationship-materialization-complex: ✅ Performance improved

✅ duration
phase estimated improvement -13ms [-22ms to -4ms] OR -0.5% [-0.84% to -0.15%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [0ms to 0ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 1ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-3ms to 5ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-6ms to 2ms]
✅ Phase [start-relationship-materialization] => [start-push-payload2]
phase estimated improvement -10ms [-18ms to -1ms] OR -0.86% [-1.49% to -0.11%]
☑️ Phase [start-push-payload2] => [start-relationship-materialization2]
phase no difference [-2ms to 5ms]
☑️ Phase [start-relationship-materialization2] => [end-relationship-materialization2]
phase no difference [-1ms to 3ms]
✅ Phase [end-relationship-materialization2] => [Test End]
phase estimated improvement -2ms [-4ms to 0ms] OR -1.36% [-2.73% to -0.18%]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 3ms]
✅ Phase [navigationStart] => [start-push-payload]
phase estimated improvement -1ms [-2ms to 0ms] OR -0.68% [-1.22% to -0.12%]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-4ms to 1ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-1ms to 1ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-3ms to 7ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-2ms to 0ms]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [-2ms to 4ms]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-1ms to 3ms]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-1ms to 4ms]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [0ms to 6ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [0ms to 1ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-2ms to 2ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-1ms to 2ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-2ms to 2ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [0ms to 1ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-2ms to 1ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-2ms to 3ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-1ms to 1ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-1ms to 3ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - update-with-same-state: ☑️ Performance is stable

☑️ duration
phase no difference [-4ms to 6ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [0ms to 0ms]
☑️ Phase [start-data-generation] => [start-push-initial-payload]
phase no difference [-1ms to 0ms]
☑️ Phase [start-push-initial-payload] => [start-peek-records]
phase no difference [-1ms to 2ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [0ms to 1ms]
☑️ Phase [start-relationship-materialization] => [start-local-removal]
phase no difference [-2ms to 3ms]
☑️ Phase [start-local-removal] => [start-push-minus-one-payload]
phase no difference [-1ms to 2ms]
✅ Phase [start-push-minus-one-payload] => [start-local-addition]
phase estimated improvement -1ms [-1ms to 0ms] OR -6.06% [-8.68% to -3.53%]
☑️ Phase [start-local-addition] => [start-push-plus-one-payload]
phase no difference [0ms to 2ms]
☑️ Phase [start-push-plus-one-payload] => [end-push-plus-one-payload]
phase no difference [-2ms to 1ms]
☑️ Phase [end-push-plus-one-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - update-with-same-state-m2m: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +4ms [1ms to 8ms] OR +0.45% [0.06% to 0.83%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [0ms to 1ms]
⚠️ Phase [start-data-generation] => [start-push-initial-payload]
phase estimated regression +1ms [0ms to 2ms] OR +0.4% [0.07% to 0.7%]
☑️ Phase [start-push-initial-payload] => [start-peek-records]
phase no difference [-2ms to 1ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-relationship-materialization] => [start-local-removal]
phase no difference [0ms to 1ms]
☑️ Phase [start-local-removal] => [start-push-minus-one-payload]
phase no difference [0ms to 2ms]
☑️ Phase [start-push-minus-one-payload] => [start-local-addition]
phase no difference [-1ms to 1ms]
⚠️ Phase [start-local-addition] => [start-push-plus-one-payload]
phase estimated regression +2ms [1ms to 3ms] OR +1.49% [0.78% to 2.24%]
☑️ Phase [start-push-plus-one-payload] => [end-push-plus-one-payload]
phase no difference [0ms to 2ms]
☑️ Phase [end-push-plus-one-payload] => [Test End]
phase no difference [0ms to 0ms]