fix: better reordering detection when remoteClearsLocal is true #9771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitKrystan
added
🎯 canary
runspired
force-pushed
the
fix-more-overnotification
branch
from
a6822af to
99de9d5
Compare
runspired
reviewed
Mar 20, 2025
| @@ -234,34 +234,24 @@ function _compare<T>( | |||
| // however: if the new remote order matches the current local order | |||
| // we can disregard the change notification generation so long as | |||
| // we are not configured to reset on remote update (which is deprecated) | |||
| if (DEPRECATE_RELATIONSHIP_REMOTE_UPDATE_CLEARING_LOCAL_STATE) { | |||
There was a problem hiding this comment.
TL;DR once we got the diffing for changed as good as we got it, we no longer needed this branch as the remaining case was covered down below
runspired
force-pushed
the
fix-more-overnotification
branch
from
7628e67 to
fb82e02
Compare
runspired
changed the title
gitKrystan
added a commit
that referenced
this pull request
Mar 21, 2025
* Fix DEPRECATE_RELATIONSHIP_REMOTE_UPDATE_CLEARING_LOCAL_STATE reordering detection * add failing test * notification tests * implement fix * cleanup console logs * fix spurrious type issue --------- Co-authored-by: Chris Thoburn <runspired@users.noreply.github.com>
gitKrystan
added a commit
that referenced
this pull request
Mar 21, 2025
* feat: schema type utils (#9757) * minor type improvements * chore: fixup types * add api docs * nice things * account for schema presence * cleanup test * chore: update contributing docs (#9758) * chore: Improve contributing experience (#9759) * chore: improve developing experience on local * more * temporarily deactivate some scenarios * deactivate more lints * deactivate more prod tests * another * chore: reduce simple Map/Set ops (#9761) * perf: faster iteration of relationship payloads (#9762) faster iteration of payloads * chore: restructure SchemaRecord test file layout to make it easier to navigate (#9763) * chore: simplify test file layout * chore: move polaris test files to new structure * docs: LinksMode and Polymorphic Relationship Guide, stubs out guide for LegacyMode vs PolarisMode (#9764) * docs: stub out guides for SchemaRecord, LinksMode, PolarisMode etc. * add linksmode guide * fix annotation * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * Update guides/relationships/features/links-mode.md Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * cleanup op * rewrite future thoughts * stub out more of the guide * add docs on polymorphism * stub out guide * add note on interop * add reactivity overview --------- Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com> * feat: improve debuggability of SchemaRecord, RecordArray and Identifier (#9766) * feat: improve debuggability of SchemaRecord, RecordArray and Identifier * fix configurability * fix keys * feat: persist runtime config (#9767) * feat: persist runtime config * ensure fastboot works * Don't set isDirty to true in diff callbacks (#9765) * More overnotification fixes * Fix DEPRECATE_RELATIONSHIP_REMOTE_UPDATE_CLEARING_LOCAL_STATE case * feat: ensure objects behave amazeballs (#9768) * feat: ensure objects behave amazeballs * add tests for record iteration * add more tests * fix(deps): update dependency @babel/runtime to v7.26.10 [security] (#9760) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: remove restriction on new field kinds being used with legacy mode * improve types * Revert "improve types" This reverts commit 84daef7. * Revert "chore: remove restriction on new field kinds being used with legacy mode" This reverts commit 3fd81bf. * Widen Peer Range for ember-inflector (#9770) * chore: remove restriction on new field kinds being used with legacy mode (#9769) * chore: remove restriction on new field kinds being used with legacy mode * chore: cleanup types * fix * fix test * fix docs * chore: cleanup @ember/service deprecation from shipped library code (#9773) * Add: tests verify behavior mutating a record (#9754) * add: tests verify behavior mutating a related record from a checked-out record * fix: lint * fix: test * fix: lint * fix: better reordering detection when remoteClearsLocal is true (#9771) * Fix DEPRECATE_RELATIONSHIP_REMOTE_UPDATE_CLEARING_LOCAL_STATE reordering detection * add failing test * notification tests * implement fix * cleanup console logs * fix spurrious type issue --------- Co-authored-by: Chris Thoburn <runspired@users.noreply.github.com> * Fix some lint --------- Co-authored-by: Chris Thoburn <runspired@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jon Johnson <jon.johnson@ucsf.edu> Co-authored-by: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes for the release