Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup deprecations #9779

Merged
merged 2 commits into from
Mar 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guides/requests/examples/1-auth.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Lets imagine we are using [Ember Simple Auth](https://github.com/simplabs/ember-
**app/services/auth-handler.js**

```ts
import { inject as service } from '@ember/service';
import { service } from '@ember/service';
import type { NextFn, RequestContext } from '@ember-data/request';

export default class AuthHandler {
Expand Down
532 changes: 134 additions & 398 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion tests/ember-data__request/tests/integration/service-test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { getOwner } from '@ember/application';
import Service, { inject as service } from '@ember/service';
import * as s from '@ember/service';
import type { TestContext } from '@ember/test-helpers';

import Resolver from 'ember-resolver';
Expand All @@ -8,6 +8,9 @@ import RequestManager from '@ember-data/request';
import { module, test } from '@warp-drive/diagnostic';
import { setupTest } from '@warp-drive/diagnostic/ember';

const Service = s.default;
const service = s.service ?? s.inject;

module('RequestManager | Ember Service Setup', function (hooks) {
setupTest(hooks, { resolver: new Resolver() });

Expand Down
4 changes: 3 additions & 1 deletion tests/fastboot/app/routes/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import * as s from '@ember/service';

// @ts-expect-error untyped
import { buildTree } from 'ember-simple-tree/utils/tree';
Expand All @@ -10,6 +10,8 @@ import { setBuildURLConfig } from '@ember-data/request-utils';
import type Person from '../models/person';
import type Store from '../services/store';

const service = s.service ?? s.inject;

export default class IndexRoute extends Route {
@service declare store: Store;
@service declare fastboot: {
Expand Down
4 changes: 3 additions & 1 deletion tests/fastboot/app/routes/person/new.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import * as s from '@ember/service';

const service = s.service ?? s.inject;

export default class PersonNewRoute extends Route {
@service store;
Expand Down
5 changes: 3 additions & 2 deletions tests/main/app/route.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import Route from '@ember/routing/route';
import { inject } from '@ember/service';
import * as s from '@ember/service';

import type Store from '@ember-data/store';

const service = s.service ?? s.inject;
export default class ApplicationRoute extends Route {
@inject declare store: Store;
@service declare store: Store;

override model() {
// adding a model to the store to enable manually testing the debug-adapter
Expand Down
5 changes: 3 additions & 2 deletions tests/main/app/routes/application.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import Route from '@ember/routing/route';
import { inject } from '@ember/service';
import * as s from '@ember/service';

import type Store from '@ember-data/store';

const service = s.service ?? s.inject;
export default class ApplicationRoute extends Route {
@inject declare store: Store;
@service declare store: Store;

override model() {
// adding a model to the store to enable manually testing the debug-adapter
Expand Down
3 changes: 3 additions & 0 deletions tests/main/ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ module.exports = async function (defaults) {

setConfig(app, __dirname, {
compatWith: isEnabled(process.env.EMBER_DATA_FULL_COMPAT) ? '99.0' : null,
deprecations: {
DEPRECATE_STORE_EXTENDS_EMBER_OBJECT: false,
},
debug: {
// LOG_GRAPH: true,
// LOG_IDENTIFIERS: true,
Expand Down
8 changes: 4 additions & 4 deletions tests/main/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@
"@glint/environment-ember-template-imports": "1.5.2",
"@glint/template": "1.5.2",
"@types/qunit": "2.19.10",
"@warp-drive/core-types": "workspace:*",
"@warp-drive/schema-record": "workspace:*",
"@warp-drive/build-config": "workspace:*",
"@warp-drive/core-types": "workspace:*",
"@warp-drive/holodeck": "workspace:*",
"@warp-drive/internal-config": "workspace:*",
"@warp-drive/schema-record": "workspace:*",
"broccoli-concat": "^4.2.5",
"broccoli-merge-trees": "^4.2.0",
"broccoli-stew": "^3.0.0",
Expand All @@ -82,12 +82,12 @@
"ember-inflector": "5.0.2",
"ember-load-initializers": "^3.0.1",
"ember-maybe-import-regenerator": "^1.0.0",
"ember-template-imports": "4.3.0",
"ember-qunit": "8.0.2",
"ember-resolver": "^11.0.1",
"ember-source": "https://s3.amazonaws.com/builds.emberjs.com/canary/shas/be20bd3f8ea066050eb91862af5180e10ba37134.tgz",
"ember-source": "~5.12.0",
"ember-source-channel-url": "^3.0.0",
"ember-strict-resolver": "^1.3.0",
"ember-template-imports": "4.3.0",
"ember-try": "^3.0.0",
"loader.js": "^4.7.0",
"pretender": "^3.4.7",
Expand Down
4 changes: 3 additions & 1 deletion tests/main/tests/acceptance/relationships/has-many-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import ArrayProxy from '@ember/array/proxy';
import { setComponentTemplate } from '@ember/component';
import { action } from '@ember/object';
import { sort } from '@ember/object/computed';
import { inject as service } from '@ember/service';
import * as s from '@ember/service';
import { click, find, findAll, render, rerender, settled } from '@ember/test-helpers';
import Component from '@glimmer/component';

Expand All @@ -18,6 +18,8 @@ import Model, { attr, belongsTo, hasMany } from '@ember-data/model';
import { LEGACY_SUPPORT } from '@ember-data/model/-private';
import JSONAPISerializer from '@ember-data/serializer/json-api';

const service = s.service ?? s.inject;

class Person extends Model {
@attr()
name;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { setComponentTemplate } from '@ember/component';
import { action } from '@ember/object';
import { inject } from '@ember/service';
import * as s from '@ember/service';
import { click, findAll, render } from '@ember/test-helpers';
import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';
Expand All @@ -12,6 +12,8 @@ import { setupRenderingTest } from 'ember-qunit';

import Model, { attr, belongsTo, hasMany } from '@ember-data/model';

const service = s.service ?? s.inject;

class Tag {
@tracked rev = 0;
}
Expand Down Expand Up @@ -54,7 +56,7 @@ module('tracking state flags on a record', function (hooks) {
}
let childId = 1;
class ChildrenList extends Component {
@inject store;
@service store;
@tracked newChild = null;

// an intentionally complicated way of resolving the async proxy
Expand Down
4 changes: 3 additions & 1 deletion tests/main/tests/acceptance/tracking-create-record-test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { setComponentTemplate } from '@ember/component';
import { inject as service } from '@ember/service';
import * as s from '@ember/service';
import { render, settled } from '@ember/test-helpers';
import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';
Expand All @@ -12,6 +12,8 @@ import { setupRenderingTest } from 'ember-qunit';
import Model, { attr } from '@ember-data/model';
import { cached, memoTransact, transact, untracked } from '@ember-data/tracking';

const service = s.service ?? s.inject;

module('acceptance/tracking-transactions', function (hooks) {
setupRenderingTest(hooks);

Expand Down
5 changes: 4 additions & 1 deletion tests/main/tests/integration/application-test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// ensure DS namespace is set
import Controller from '@ember/controller';
import Service, { inject as service } from '@ember/service';
import * as s from '@ember/service';

import { module, test } from 'qunit';

Expand All @@ -9,6 +9,9 @@ import { setupTest } from 'ember-qunit';

import JSONAPIAdapter from '@ember-data/adapter/json-api';

const Service = s.default;
const service = s.service ?? s.inject;

module('integration/application - Injecting a Custom Store', function (hooks) {
setupTest(hooks);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { inject as service } from '@ember/service';
import * as s from '@ember/service';

import { module, test } from 'qunit';

Expand Down Expand Up @@ -30,6 +30,8 @@ import type {
import type { ExistingResourceObject, ResourceIdentifierObject } from '@warp-drive/core-types/spec/json-api-raw';
import type { Type } from '@warp-drive/core-types/symbols';

const service = s.service ?? s.inject;

type FakeRecord = { [key: string]: unknown; destroy: () => void };
type UserRecord = {
id: string;
Expand Down
4 changes: 3 additions & 1 deletion tests/main/tests/integration/store-extension-test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { inject as service } from '@ember/service';
import * as s from '@ember/service';

import { module, test } from 'qunit';

Expand All @@ -7,6 +7,8 @@ import { setupTest } from 'ember-qunit';

import RequestManager from '@ember-data/request';

const service = s.service ?? s.inject;

module('Integration | Store Extension', function (hooks) {
setupTest(hooks);

Expand Down
7 changes: 5 additions & 2 deletions tests/main/tests/integration/store/model-name-test.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
import { computed } from '@ember/object';
import Service, { inject } from '@ember/service';
import * as s from '@ember/service';

import { module, test } from 'qunit';

import { setupTest } from 'ember-qunit';

import Model, { attr } from '@ember-data/model';

const Service = s.default;
const service = s.service ?? s.inject;

function startsWith(str, substr) {
if (typeof str.startsWith === 'function') {
return str.startsWith(substr);
Expand All @@ -26,7 +29,7 @@ module('@ember-data/model klass.modelName', function (hooks) {
@attr() name;
}
class AnimalHelper extends Service {
@inject store;
@service store;

@computed('animal.constructor.modelName')
get animalModelName() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

export default Route.extend({
store: service(),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

export default Route.extend({
store: service(),
Expand Down
2 changes: 1 addition & 1 deletion tests/performance/app/routes/add-children.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

export default Route.extend({
store: service(),
Expand Down
2 changes: 1 addition & 1 deletion tests/performance/app/routes/destroy.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

import { deleteRecord } from '@ember-data/json-api/request';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

export default Route.extend({
store: service(),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

import { query } from '@ember-data/json-api/request';

Expand Down
2 changes: 1 addition & 1 deletion tests/performance/app/routes/unload-all.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

export default Route.extend({
store: service(),
Expand Down
2 changes: 1 addition & 1 deletion tests/performance/app/routes/unload.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

export default Route.extend({
store: service(),
Expand Down
2 changes: 1 addition & 1 deletion tests/performance/app/routes/unused-relationships.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

/**
* Measures the performance characteristics of pushing a large payload
Expand Down
2 changes: 1 addition & 1 deletion tests/performance/app/routes/update-with-same-state-m2m.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable no-console */
/* eslint-disable no-undef */
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

const DEBUG = false;

Expand Down
2 changes: 1 addition & 1 deletion tests/performance/app/routes/update-with-same-state.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { service } from '@ember/service';

export default Route.extend({
store: service(),
Expand Down
Loading