Handle case when sessionStorage is blocked #9785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
approved these changes
Mar 25, 2025
runspired
added
🎯 canary
gitKrystan
pushed a commit
that referenced
this pull request
Apr 1, 2025
gitKrystan
added a commit
that referenced
this pull request
Apr 1, 2025
* chore: improve contributing guidance for api documentation (#9778) * chore: cleanup deprecations (#9779) * docs: update overviews with recent library improvements (#9777) * docs: update overviews with recent library improvements * make docs preview even easier * update more docs * begin adding ember docs * add all the docs * docs: enable canary previews * chore: fix workflow indentation * make setup more robust * fix boolean check in yml * yml: your mileage lags * fix deploy * docs: improve schema-record documentation (#9781) * chore: improve schema-record documentation * add more docs for fields * chore: add class coverage to docs tests (#9782) * docs: expand field docs (#9783) * Handle case when sessionStorage is blocked (#9785) * chore(config): migrate renovate config (#9793) chore(config): migrate config .github/renovate.json Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency bun-types to v1.2.5 (#9789) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ember-core (#9791) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency qunit-dom to ^3.4.0 (#9790) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: make warnMessageNoModelForKey safe in prod (#9885) * Backport pnpm-lock.yaml changes * Backport docs-viewer * Fix docs test expectations --------- Co-authored-by: Chris Thoburn <runspired@users.noreply.github.com> Co-authored-by: eth3lbert <eth3lbert+dev@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to retrieve session storage within a try catch block to handle cases where it is blocked.
This should resolve #9784.