Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release plan #2563

Merged
merged 2 commits into from
Apr 9, 2024
Merged

add release plan #2563

merged 2 commits into from
Apr 9, 2024

Conversation

patricklx
Copy link
Collaborator

@patricklx patricklx commented Mar 12, 2024

i think it would be nice to have release-plan here as well

@patricklx
Copy link
Collaborator Author

@NullVoxPopuli can you have a look if this setup is correct?
especiially because we have scheduled release as well (nightly) to npm as well. Does pnpm release-plan also create a github tag & release. and is it disabled of tag=alpha ?

@RobbieTheWagner
Copy link
Member

We cannot do automated releases because releasing to the Chrome store doesn't work. We need to find a way to get a new token or whatever for that.

@patricklx
Copy link
Collaborator Author

But we are already doing it. This just gives a nice preview PR that can be merged to trigger the publishing.
You probably need to get a new refresh token?

@patricklx
Copy link
Collaborator Author

patricklx commented Mar 12, 2024

Found this:
https://github.com/PlasmoHQ/chrome-webstore-api/blob/main/token.md

Apparently it should be possible to use the same refresh token and client ID for multiple extensions.
We can try using the refresh token from the nightly extension. That one is working

@patricklx
Copy link
Collaborator Author

Another thing i found:
Looks like refresh token expire after 60days of no usage. One more reason to use the same as nightly.

Or just do a custom token fetch :
https://dev.to/cardinalby/dont-let-google-refresh-token-expire-pie

@patricklx
Copy link
Collaborator Author

@RobbieTheWagner i updated the publishing to use the same token as nightly

@RobbieTheWagner
Copy link
Member

@RobbieTheWagner i updated the publishing to use the same token as nightly

You are sure that is okay? I am not sure why we had separate ones before.

@patricklx
Copy link
Collaborator Author

patricklx commented Mar 12, 2024

@RobbieTheWagner i updated the publishing to use the same token as nightly

You are sure that is okay? I am not sure why we had separate ones before.

Not really:) but probably if they are under the same account.
Worst case is that publishing will fail and you have to do it manually

@NullVoxPopuli
Copy link
Contributor

can you have a look if this setup is correct?

I'm nervous about non-boilerplate versions of the workflows 😅
One of the things I like about release-plan is that I (for the most part) don't need to think about what's going in to the workflows -- there's been one exception so far, but the change was small.

Personally, I think we should keep extension publishing separate, but have it run on the condition that the publish.yml (to npm) has completed successfully -- that way we can still manage our custom stuff separately from the boilerplate (which should be more easily replaceable via npx create-release-plan-setup@latest --update)

@patricklx patricklx marked this pull request as draft March 12, 2024 22:41
@patricklx
Copy link
Collaborator Author

patricklx commented Mar 13, 2024

I changed the flow to let release plan make the publishing & tag & release. With minimal changes
after it created the github tag, build.yml will be triggered.

@patricklx patricklx force-pushed the patch-18 branch 2 times, most recently from 297a100 to fccaf96 Compare March 13, 2024 09:15
@patricklx patricklx marked this pull request as ready for review March 13, 2024 09:16
@patricklx
Copy link
Collaborator Author

patricklx commented Mar 13, 2024

this is ready now @RobbieTheWagner

@RobbieTheWagner
Copy link
Member

@NullVoxPopuli does this seem correct to you? I am not super familiar with release-plan, but would love to introduce it here.

@NullVoxPopuli
Copy link
Contributor

yeah, as long as its known that the firefox/chrome extensions still need manual publishing

@patricklx
Copy link
Collaborator Author

yeah, as long as its known that the firefox/chrome extensions still need manual publishing

the release-it will create a tag which then triggers the firefox/chrome publishing

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If NVP thinks it looks good, good enough for me. Thanks for the PR!

@RobbieTheWagner RobbieTheWagner merged commit 9b226da into emberjs:main Apr 9, 2024
14 checks passed
@patricklx patricklx deleted the patch-18 branch April 9, 2024 13:52
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants