-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add release plan #2563
add release plan #2563
Conversation
@NullVoxPopuli can you have a look if this setup is correct? |
We cannot do automated releases because releasing to the Chrome store doesn't work. We need to find a way to get a new token or whatever for that. |
But we are already doing it. This just gives a nice preview PR that can be merged to trigger the publishing. |
Found this: Apparently it should be possible to use the same refresh token and client ID for multiple extensions. |
Another thing i found: Or just do a custom token fetch : |
@RobbieTheWagner i updated the publishing to use the same token as nightly |
You are sure that is okay? I am not sure why we had separate ones before. |
Not really:) but probably if they are under the same account. |
I'm nervous about non-boilerplate versions of the workflows 😅 Personally, I think we should keep extension publishing separate, but have it run on the condition that the publish.yml (to npm) has completed successfully -- that way we can still manage our custom stuff separately from the boilerplate (which should be more easily replaceable via |
I changed the flow to let release plan make the publishing & tag & release. With minimal changes |
297a100
to
fccaf96
Compare
this is ready now @RobbieTheWagner |
@NullVoxPopuli does this seem correct to you? I am not super familiar with release-plan, but would love to introduce it here. |
yeah, as long as its known that the firefox/chrome extensions still need manual publishing |
the release-it will create a tag which then triggers the firefox/chrome publishing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If NVP thinks it looks good, good enough for me. Thanks for the PR!
i think it would be nice to have release-plan here as well