Removing reset

Author: scalvert

addon-test-support/ember-qunit/-internal/test-debug-info-summary.js

@@ -24,7 +24,16 @@ export function getSummary(testCounts, leakCounts, testNames) {
 
 export default class TestDebugInfoSummary {
   constructor() {
-    this.reset();
+    this._testDebugInfos = [];
+    this.fullTestNames = [];
+    this.hasPendingRequests = false;
+    this.hasPendingWaiters = false;
+    this.hasRunLoop = false;
+    this.hasPendingTimers = false;
+    this.hasPendingScheduledQueueItems = false;
+    this.totalPendingRequestCount = 0;
+    this.totalPendingTimersCount = 0;
+    this.totalPendingScheduledQueueItemCount = 0;
   }
 
   add(testDebugInfo) {
@@ -58,19 +67,6 @@ export default class TestDebugInfoSummary {
     return this._testDebugInfos.length > 0;
   }
 
-  reset() {
-    this._testDebugInfos = [];
-    this.fullTestNames = [];
-    this.hasPendingRequests = false;
-    this.hasPendingWaiters = false;
-    this.hasRunLoop = false;
-    this.hasPendingTimers = false;
-    this.hasPendingScheduledQueueItems = false;
-    this.totalPendingRequestCount = 0;
-    this.totalPendingTimersCount = 0;
-    this.totalPendingScheduledQueueItemCount = 0;
-  }
-
   printToConsole(_console = console) {
     _console.group('Tests not isolated');
 

addon-test-support/ember-qunit/test-isolation-validation.js

@@ -4,8 +4,8 @@ import TestDebugInfo from './-internal/test-debug-info';
 import TestDebugInfoSummary from './-internal/test-debug-info-summary';
 import getDebugInfoAvailable from './-internal/get-debug-info-available';
 
-const nonIsolatedTests = new TestDebugInfoSummary();
 const { backburner } = run;
+let nonIsolatedTests;
 
 /**
  * Detects if a specific test isn't isolated. A test is considered
@@ -22,6 +22,8 @@ const { backburner } = run;
  * @param {string} testInfo.name The test name
  */
 export function detectIfTestNotIsolated({ module, name }) {
+  nonIsolatedTests = new TestDebugInfoSummary();
+
   if (!isSettled()) {
     let testDebugInfo;
     let backburnerDebugInfo;
@@ -47,7 +49,6 @@ export function detectIfTestNotIsolated({ module, name }) {
 export function reportIfTestNotIsolated() {
   if (nonIsolatedTests.hasDebugInfo) {
     nonIsolatedTests.printToConsole();
-    nonIsolatedTests.reset();
 
     throw new Error(nonIsolatedTests.formatForBrowser());
   }

tests/unit/test-debug-info-summary-test.js

@@ -15,21 +15,6 @@ module('TestDebugInfoSummary', function() {
     assert.ok(testDebugInfoSummary.hasDebugInfo);
   });
 
-  test('reset correctly resets to default values', function(assert) {
-    assert.expect(2);
-
-    let testDebugInfoSummary = new TestDebugInfoSummary();
-
-    testDebugInfoSummary.add(new TestDebugInfo('foo', 'bar', {}));
-    testDebugInfoSummary.add(new TestDebugInfo('ding', 'bat', {}));
-
-    assert.ok(testDebugInfoSummary.hasDebugInfo);
-
-    testDebugInfoSummary.reset();
-
-    assert.notOk(testDebugInfoSummary.hasDebugInfo);
-  });
-
   test('printToConsole correctly prints minimal information', function(assert) {
     assert.expect(1);