Skip to content

Commit 5bb5f1b

Browse files
ctjhoactjhoa
committed
Move to addon v2
1 parent 7dcc032 commit 5bb5f1b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+3707
-2473
lines changed

‎.github/workflows/ci.yml

+10-14
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,15 @@ jobs:
2222
steps:
2323
- uses: actions/checkout@v2
2424
- name: Install Node
25-
uses: actions/setup-node@v2
26-
with:
27-
node-version: 12.x
28-
cache: yarn
25+
uses: volta-cli/action@v1
2926
- name: Install Dependencies
3027
run: yarn install --frozen-lockfile
31-
- name: Lint
28+
- name: Lint Addon
3229
run: yarn lint
30+
working-directory: packages/ember-render-modifiers
31+
- name: Lint Test App
32+
run: yarn lint
33+
working-directory: packages/test-app
3334
- name: Run Tests
3435
run: yarn test:ember
3536

@@ -39,14 +40,11 @@ jobs:
3940

4041
steps:
4142
- uses: actions/checkout@v2
42-
- uses: actions/setup-node@v2
43-
with:
44-
node-version: 12.x
45-
cache: yarn
43+
- uses: volta-cli/action@v1
4644
- name: Install Dependencies
4745
run: yarn install --no-lockfile
4846
- name: Run Tests
49-
run: yarn test:ember
47+
run: yarn test
5048

5149
try-scenarios:
5250
name: ${{ matrix.try-scenario }}
@@ -74,11 +72,9 @@ jobs:
7472
steps:
7573
- uses: actions/checkout@v2
7674
- name: Install Node
77-
uses: actions/setup-node@v2
78-
with:
79-
node-version: 12.x
80-
cache: yarn
75+
uses: volta-cli/action@v1
8176
- name: Install Dependencies
8277
run: yarn install --frozen-lockfile
8378
- name: Run Tests
8479
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
80+
working-directory: packages/test-app

‎.gitignore

+5-28
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,6 @@
1-
# See https://help.github.com/ignore-files/ for more about ignoring files.
1+
# you definitely want this:
2+
node_modules
23

3-
# compiled output
4-
/dist/
5-
/tmp/
6-
7-
# dependencies
8-
/bower_components/
9-
/node_modules/
10-
11-
# misc
12-
/.env*
13-
/.pnp*
14-
/.sass-cache
15-
/.eslintcache
16-
/connect.lock
17-
/coverage/
18-
/libpeerconnection.log
19-
/npm-debug.log*
20-
/testem.log
21-
/yarn-error.log
22-
23-
# ember-try
24-
/.node_modules.ember-try/
25-
/bower.json.ember-try
26-
/npm-shrinkwrap.json.ember-try
27-
/package.json.ember-try
28-
/package-lock.json.ember-try
29-
/yarn.lock.ember-try
4+
# and you can put in anything else that tends to accumulate in your environment:
5+
yarn-error.log
6+
.DS_Store

‎app/modifiers/did-insert.js

-1
This file was deleted.

‎app/modifiers/did-update.js

-1
This file was deleted.

‎app/modifiers/will-destroy.js

-1
This file was deleted.

‎ember-cli-build.js

-25
This file was deleted.

‎index.js

-5
This file was deleted.

‎package.json

+32-81
Original file line numberDiff line numberDiff line change
@@ -1,95 +1,46 @@
11
{
2-
"name": "@ember/render-modifiers",
3-
"version": "2.0.4",
4-
"description": "Implements did-insert / did-update / will-destry modifiers for emberjs/rfcs#415",
5-
"keywords": [
6-
"ember-addon"
7-
],
8-
"repository": "git@github.com:emberjs/ember-render-modifiers.git",
9-
"license": "MIT",
10-
"author": "Robert Jackson <me@rwjblue>",
11-
"main": "index.js",
12-
"directories": {
13-
"doc": "doc",
14-
"test": "tests"
15-
},
2+
"private": true,
3+
"workspaces": ["packages/*"],
164
"scripts": {
17-
"build": "ember build --environment=production",
5+
"prepare": "yarn workspace @ember/render-modifiers run prepare",
6+
"start": "npm-run-all --parallel start:*",
7+
"start:addon": "yarn workspace @ember/render-modifiers run start",
8+
"start:test-app": "yarn workspace test-app run start",
189
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel \"lint:!(fix)\"",
19-
"lint:fix": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*:fix",
20-
"lint:hbs": "ember-template-lint .",
21-
"lint:hbs:fix": "ember-template-lint . --fix",
22-
"lint:js": "eslint . --cache",
23-
"lint:js:fix": "eslint . --fix",
24-
"start": "ember serve",
25-
"test": "npm-run-all lint test:*",
26-
"test:ember": "ember test",
27-
"test:ember-compatibility": "ember try:each"
28-
},
29-
"dependencies": {
30-
"@embroider/macros": "^1.0.0",
31-
"ember-cli-babel": "^7.26.11",
32-
"ember-modifier-manager-polyfill": "^1.2.0"
10+
"lint:addon": "yarn workspace @ember/render-modifiers run lint",
11+
"lint:test-app": "yarn workspace test-app run lint",
12+
"lint:fix": "npm-run-all --aggregate-output --continue-on-error --parallel lint:fix:*",
13+
"lint:fix:addon": "yarn workspace @ember/render-modifiers run lint:fix",
14+
"lint:fix:test-app": "yarn workspace test-app run lint:fix",
15+
"test": "npm-run-all --aggregate-output --continue-on-error --parallel \"test:!(watch)\"",
16+
"test:watch": "npm-run-all --aggregate-output --continue-on-error --parallel test:watch:*",
17+
"test:test-app": "yarn workspace test-app run test",
18+
"test:watch:test-app": "yarn workspace test-app run test:watch",
19+
"test:watch:addon": "yarn workspace @ember/render-modifiers run start",
20+
"release": "release-it"
21+
},
22+
"volta": {
23+
"node": "16.14.2",
24+
"yarn": "1.22.17"
3325
},
3426
"devDependencies": {
35-
"@ember/optional-features": "^2.0.0",
36-
"@ember/test-helpers": "^2.6.0",
37-
"@embroider/test-setup": "^1.0.0",
38-
"@embroider/util": "^1.0.0",
39-
"@glimmer/component": "^1.0.4",
40-
"@glimmer/tracking": "^1.0.4",
41-
"babel-eslint": "^10.1.0",
42-
"ember-auto-import": "^2.2.4",
43-
"ember-cli": "~4.1.0",
44-
"ember-cli-dependency-checker": "^3.2.0",
45-
"ember-cli-htmlbars": "^6.0.1",
46-
"ember-cli-inject-live-reload": "^2.1.0",
47-
"ember-cli-terser": "^4.0.2",
48-
"ember-disable-prototype-extensions": "^1.1.3",
49-
"ember-load-initializers": "^2.1.2",
50-
"ember-page-title": "^7.0.0",
51-
"ember-qunit": "^5.1.5",
52-
"ember-resolver": "^8.0.3",
53-
"ember-source": "~4.1.0",
54-
"ember-source-channel-url": "^3.0.0",
55-
"ember-template-lint": "^3.15.0",
56-
"ember-try": "^2.0.0",
57-
"eslint": "^7.32.0",
58-
"eslint-config-prettier": "^8.3.0",
59-
"eslint-plugin-ember": "^10.5.8",
60-
"eslint-plugin-node": "^11.1.0",
61-
"eslint-plugin-prettier": "^4.0.0",
62-
"eslint-plugin-qunit": "^7.2.0",
63-
"loader.js": "^4.7.0",
6427
"npm-run-all": "^4.1.5",
65-
"prettier": "^2.5.1",
66-
"qunit": "^2.17.2",
67-
"qunit-dom": "^2.0.0",
68-
"release-it": "^14.11.6",
69-
"release-it-lerna-changelog": "^3.1.0",
70-
"webpack": "^5.65.0"
71-
},
72-
"peerDependencies": {
73-
"ember-source": "^3.8 || 4"
74-
},
75-
"engines": {
76-
"node": "12.* || 14.* || >= 16"
77-
},
78-
"publishConfig": {
79-
"access": "public",
80-
"registry": "https://registry.npmjs.org"
81-
},
82-
"ember": {
83-
"edition": "octane"
84-
},
85-
"ember-addon": {
86-
"configPath": "tests/dummy/config"
28+
"release-it": "^14.0.0",
29+
"release-it-lerna-changelog": "^4.0.1",
30+
"release-it-yarn-workspaces": "^2.0.1"
8731
},
8832
"release-it": {
8933
"plugins": {
9034
"release-it-lerna-changelog": {
9135
"infile": "CHANGELOG.md",
92-
"launchEditor": true
36+
"launchEditor": false
37+
},
38+
"release-it-yarn-workspaces": {
39+
"workspaces": ["packages/ember-render-modifiers"],
40+
"additionalManifests": {
41+
"dependencyUpdates": ["packages/test-app/package.json"],
42+
"versionUpdates": ["packages/test-app/package.json"]
43+
}
9344
}
9445
},
9546
"git": {

‎packages/ember-render-modifiers/.gitignore

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# The authoritative copies of these live in the monorepo root (because they're
2+
# more useful on github that way), but the build copies them into here so they
3+
# will also appear in published NPM packages.
4+
/README.md
5+
/LICENSE.md
6+
/CONTRIBUTING.md
7+
/RELEASE.md
8+
/CHANGELOG.md

‎packages/ember-render-modifiers/CHANGELOG.md

+111
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
1+
2+
3+
4+
5+
## v2.0.4 (2022-02-01)
6+
7+
#### :bug: Bug Fix
8+
* [#59](https://github.com/emberjs/ember-render-modifiers/pull/59) Update embroider to v1.0.0 ([@jrjohnson](https://github.com/jrjohnson))
9+
10+
#### :house: Internal
11+
* [#60](https://github.com/emberjs/ember-render-modifiers/pull/60) ember-cli 4.1.0 ([@rwwagner90](https://github.com/rwwagner90))
12+
13+
#### Committers: 2
14+
- Jon Johnson ([@jrjohnson](https://github.com/jrjohnson))
15+
- Robert Wagner ([@rwwagner90](https://github.com/rwwagner90))
16+
17+
## v2.0.3 (2022-01-13)
18+
19+
#### :bug: Bug Fix
20+
* [#58](https://github.com/emberjs/ember-render-modifiers/pull/58) dependencySatisfies only reliable with a peerDep ([@ef4](https://github.com/ef4))
21+
22+
#### Committers: 1
23+
- Edward Faulkner ([@ef4](https://github.com/ef4))
24+
25+
## v2.0.2 (2021-12-14)
26+
27+
#### :house: Internal
28+
* [#57](https://github.com/emberjs/ember-render-modifiers/pull/57) Fully migrate to @embroider/macros ([@rwjblue](https://github.com/rwjblue))
29+
30+
#### Committers: 1
31+
- Robert Jackson ([@rwjblue](https://github.com/rwjblue))
32+
33+
34+
## v2.0.1 (2021-12-14)
35+
36+
#### :bug: Bug Fix
37+
* [#54](https://github.com/emberjs/ember-render-modifiers/pull/54) Ensure `did-update` only re-runs when arguments change (avoid recomputing when tracked properties update within callback) ([@mogstad](https://github.com/mogstad))
38+
39+
#### :memo: Documentation
40+
* [#55](https://github.com/emberjs/ember-render-modifiers/pull/55) Migrate examples to use `@action` ([@bekzod](https://github.com/bekzod))
41+
* [#56](https://github.com/emberjs/ember-render-modifiers/pull/56) Fixes code examples in README ([@skaterdav85](https://github.com/skaterdav85))
42+
43+
#### Committers: 3
44+
- Bjarne Mogstad ([@mogstad](https://github.com/mogstad))
45+
- David Tang ([@skaterdav85](https://github.com/skaterdav85))
46+
- [@bekzod](https://github.com/bekzod)
47+
48+
49+
## v2.0.0 (2021-10-06)
50+
51+
#### :boom: Breaking Change
52+
* [#46](https://github.com/emberjs/ember-render-modifiers/pull/46) Update Ember to v3.28.0, drop node 10 support ([@SergeAstapov](https://github.com/SergeAstapov))
53+
* [#40](https://github.com/emberjs/ember-render-modifiers/pull/40) Update ember to v3.27.0, drop support for node < 10 ([@kiwiupover](https://github.com/kiwiupover))
54+
55+
#### :rocket: Enhancement
56+
* [#42](https://github.com/emberjs/ember-render-modifiers/pull/42) Update manager capabilities to 3.22 to fix deprecation in Ember 3.26+ ([@SergeAstapov](https://github.com/SergeAstapov))
57+
* [#29](https://github.com/emberjs/ember-render-modifiers/pull/29) Use destructuring in `did-insert` modifier to allow better IDE integration (template argument hints) ([@patricklx](https://github.com/patricklx))
58+
59+
#### :house: Internal
60+
* [#48](https://github.com/emberjs/ember-render-modifiers/pull/48) Update release it ([@rwwagner90](https://github.com/rwwagner90))
61+
* [#43](https://github.com/emberjs/ember-render-modifiers/pull/43) Fix deprecations in tests ([@SergeAstapov](https://github.com/SergeAstapov))
62+
* [#44](https://github.com/emberjs/ember-render-modifiers/pull/44) Use ember-auto-import 2 ([@rwwagner90](https://github.com/rwwagner90))
63+
64+
#### Committers: 6
65+
- Dave Laird ([@kiwiupover](https://github.com/kiwiupover))
66+
- Jordan Hawker ([@elwayman02](https://github.com/elwayman02))
67+
- Robert Wagner ([@rwwagner90](https://github.com/rwwagner90))
68+
- Sergey Astapov ([@SergeAstapov](https://github.com/SergeAstapov))
69+
- [@NullVoxPopuli](https://github.com/NullVoxPopuli)
70+
- [@patricklx](https://github.com/patricklx)
71+
72+
73+
## v1.0.2 (2019-10-03)
74+
75+
#### :bug: Bug Fix
76+
77+
- [#16](https://github.com/emberjs/ember-render-modifiers/pull/16) Disable modifier auto-tracking. ([@rwjblue](https://github.com/rwjblue))
78+
79+
#### Committers: 1
80+
81+
- Robert Jackson ([@rwjblue](https://github.com/rwjblue))
82+
83+
## v1.0.1 (2019-08-23)
84+
85+
#### :bug: Bug Fix
86+
87+
- [#13](https://github.com/emberjs/ember-render-modifiers/pull/13) Avoid modifier manager capabilities deprecation ([@wongpeiyi](https://github.com/wongpeiyi))
88+
89+
#### :memo: Documentation
90+
91+
- [#9](https://github.com/emberjs/ember-render-modifiers/pull/9) Update docs to use the @action decorator ([@GavinJoyce](https://github.com/GavinJoyce))
92+
- [#8](https://github.com/emberjs/ember-render-modifiers/pull/8) `{{did-insert}}`, `{{did-update}}` and `{{will-destroy}}` API docs ([@GavinJoyce](https://github.com/GavinJoyce))
93+
- [#7](https://github.com/emberjs/ember-render-modifiers/pull/7) Fixup bugs in README examples ([@GavinJoyce](https://github.com/GavinJoyce))
94+
- [#3](https://github.com/emberjs/ember-render-modifiers/pull/3) Begin fleshing out README with info from emberjs/rfcs#415. ([@rwjblue](https://github.com/rwjblue))
95+
96+
#### Committers: 4
97+
98+
- Gavin Joyce ([@GavinJoyce](https://github.com/GavinJoyce))
99+
- Ilya Radchenko ([@knownasilya](https://github.com/knownasilya))
100+
- Robert Jackson ([@rwjblue](https://github.com/rwjblue))
101+
- Wong Pei Yi ([@wongpeiyi](https://github.com/wongpeiyi))
102+
103+
## v1.0.0 (2019-01-29)
104+
105+
#### :rocket: Enhancement
106+
107+
- [#1](https://github.com/emberjs/ember-render-modifiers/pull/1) Initial implementation of emberjs/rfcs#415 ([@rwjblue](https://github.com/rwjblue))
108+
109+
#### Committers: 1
110+
111+
- Robert Jackson ([@rwjblue](https://github.com/rwjblue))

‎packages/ember-render-modifiers/CONTRIBUTING.md

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# How To Contribute
2+
3+
## Installation
4+
5+
- `git clone <repository-url>`
6+
- `cd @ember/render-modifiers`
7+
- `yarn install`
8+
9+
## Linting
10+
11+
- `yarn lint`
12+
- `yarn lint:fix`
13+
14+
## Running tests
15+
16+
- `ember test` – Runs the test suite on the current Ember version
17+
- `ember test --server` – Runs the test suite in "watch mode"
18+
- `ember try:each` – Runs the test suite against multiple Ember versions
19+
20+
## Running the dummy application
21+
22+
- `ember serve`
23+
- Visit the dummy application at [http://localhost:4200](http://localhost:4200).
24+
25+
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

0 commit comments

Comments
 (0)