-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make release-able by fixing repository
in package.json
#80
Conversation
a0f3ade
to
2d6b001
Compare
@jrjohnson before we release this, I think it needs some basic maintenance—probably mostly just a bunch of dep updates. I am happy to take a little time to review that kind of maintenance PR, so feel free to ping me—but we should definitely do that before trying to release this, because we will otherwise likely just be foisting these exact issues on downstream consumers. Going to mark this particular PR as blocked until that’s the case, and we also will not be able to do a release until then! |
Without this: ``` ERROR npm warn publish npm auto-corrected some errors in your package.json when publishing. Please run "npm pkg fix" to address these errors. ``` Running `npm pkg fix` results in this change.
2d6b001
to
4a369fc
Compare
@jrjohnson this landed; anything else you think should be done before releasing a v3.0.0? (I’m not in a hurry, it can be tomorrow or later this week!) |
I think this is ready for |
@jrjohnson I infer your thinking here is that way people on Ember v6 could upgrade to ember-render-modifiers v3 even if they’re not ready to consume a v2 addon, and then once they are, go ahead and upgrade to ember-render-modifiers v4? Assuming so, that seems reasonable to me. Once you confirm, I’ll do a release. 👍🏼 |
Oooh that too 😁, I was just worried about too much change all in one release. But we absolutely should have a release for non-v2-addon, but yes Ember 6, apps. |
@chriskrycho do you have time to do the release today? |
@jrjohnson turns out I no longer have permission (which is good!), but I’ve let other folks who are still on Framework Core that this all seems good to release. |
Thanks for the update @chriskrycho, let me know if there is anything I can do to help you find someone. Once we get this release done I've got the |
Sorry to keep bothering you @chriskrycho, any update on this? Or someone else I should be pinging? |
Oh, very sorry, I meant to reply but lost track of this over the holidays! Folks still active on Framework Core would be the best ones, I think. |
Without this:
Doing so results in this change.