Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to V2 Addon #87

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

jrjohnson
Copy link
Contributor

Ran pnpx ember-cli@latest addon @ember/render-modifiers -b @embroider/addon-blueprint --pnpm --skip-install --skip-git --typescript --addon-location=ember-render-modifiers and created everything from scratch then copied in modifiers, tests, and the PNPM version setting from ci.yml

Superseeds #66

Todo:

  • I'm not a typescript user, I used the typescript blueprint, but I don't know how to move the current types into this code. I'd assume declare them officially in the modifiers, but I don't know how to do that.
  • I'm not a release-it user and it doesn't seem to be part of the add-on blueprint anymore, this will need to be configured to work with the ember process.

@jrjohnson jrjohnson mentioned this pull request Mar 17, 2025
Ran `pnpx ember-cli@latest addon @ember/render-modifiers -b
@embroider/addon-blueprint --pnpm --skip-install --skip-git --typescript
--addon-location=ember-render-modifiers` and created everything from
scratch then copied in modifiers, tests, and the PNPM version setting
from ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant