Also test against strictest embroider

Author: NullVoxPopuli

.github/workflows/ci-build.yml

@@ -13,26 +13,42 @@ on:
 jobs:
   test:
     timeout-minutes: 10
-    name: Tests
+    name: "Tests: ${{ matrix.EMBROIDER && 'embroider' || 'classic' }}"
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        EMBROIDER:
+          - '' # classic
+          - 'true'
 
     steps:
       - uses: actions/checkout@v4
       - uses: wyvox/action-setup-pnpm@v3
       - run: pnpm lint
       - run: pnpm test:ember
         working-directory: test-apps/base-tests
+        env: 
+          EMBROIDER: ${{ matrix.EMBROIDER }}
 
   floating-dependencies:
     timeout-minutes: 10
-    name: "Floating Dependencies"
+    name: "Floating Dependencies: ${{ matrix.EMBROIDER && 'embroider' || 'classic' }}"
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        EMBROIDER:
+          - '' # classic
+          - 'true'
 
     steps:
       - uses: actions/checkout@v4
       - uses: wyvox/action-setup-pnpm@v3
       - run: pnpm test:ember
         working-directory: test-apps/base-tests
+        env: 
+          EMBROIDER: ${{ matrix.EMBROIDER }}
 
   try-scenarios:
     timeout-minutes: 10

test-apps/base-tests/ember-cli-build.js

@@ -9,5 +9,25 @@ module.exports = function (defaults) {
     // Add options here
   });
 
+  if (process.env.EMBROIDER) {
+    const { Webpack } = require('@embroider/webpack');
+
+    return require('@embroider/compat').compatBuild(app, Webpack, {
+      extraPublicTrees: [],
+      staticAddonTrees: true,
+      staticAddonTestSupportTrees: true,
+      staticHelpers: true,
+      staticModifiers: true,
+      staticComponents: true,
+      staticEmberSource: true,
+      packagerOptions: {
+        webpackConfig: {
+          // Highest fidelity source map (at the cost of build speed)
+          devtool: 'source-map',
+        },
+      },
+    });
+  }
+
   return app.toTree();
 };

test-apps/base-tests/package.json

@@ -22,6 +22,7 @@
     "lint:js:fix": "eslint . --fix",
     "lint:types": "tsc --noEmit",
     "start": "ember serve",
+    "start:embroider": "EMBROIDER=1 ember serve",
     "test": "concurrently \"npm:lint\" \"npm:test:*\" --names \"lint,test:\"",
     "test:ember": "ember test",
     "test:ember-compatibility": "ember try:each",