Fix the addon's own type checking

Author: NullVoxPopuli

addon/addon/build-waiter.ts

@@ -35,7 +35,7 @@ class TestWaiterImpl<T extends object | Primitive = Token> implements TestWaiter
     this._register();
 
     if (this.items.has(token)) {
-      throw new Error(`beginAsync called for ${token} but it is already pending.`);
+      throw new Error(`beginAsync called for ${token as string} but it is already pending.`);
     }
 
     let error = new Error();
@@ -112,7 +112,7 @@ class NoopTestWaiter implements TestWaiter {
     return this;
   }
 
-  endAsync(): void {}
+  endAsync(): void { }
 
   waitUntil(): boolean {
     return true;
@@ -122,7 +122,7 @@ class NoopTestWaiter implements TestWaiter {
     return [];
   }
 
-  reset(): void {}
+  reset(): void { }
 }
 
 /**

addon/addon/waiter-manager.ts

@@ -8,7 +8,7 @@ type Indexable = Record<any, unknown>;
 // this ensures that if @ember/test-waiters exists in multiple places in the
 // build output we will still use a single map of waiters (there really should
 // only be one of them, or else `settled` will not work at all)
-const WAITERS: Map<WaiterName, Waiter> = (function () {
+const WAITERS: Map<WaiterName, Waiter> = (function() {
   const HAS_SYMBOL = typeof Symbol !== 'undefined';
 
   let symbolName = 'TEST_WAITERS';
@@ -33,6 +33,7 @@ function getGlobal(): Indexable {
   if (typeof globalThis !== 'undefined') return indexable(globalThis);
   if (typeof self !== 'undefined') return indexable(self);
   if (typeof window !== 'undefined') return indexable(window);
+  // @ts-expect-error cannot find name 'global' -- for old compatibility
   if (typeof global !== 'undefined') return indexable(global);
 
   throw new Error('unable to locate global object');

addon/tsconfig.json

@@ -4,6 +4,9 @@
     "allowJs": true,
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,
+    // have to use this, because the current TS setup errors with ember's own types
+    // this will be fixed during v2 addon conversion
+    "skipLibCheck": true,
     "noImplicitAny": true,
     "noImplicitThis": true,
     "alwaysStrict": true,

package.json

@@ -17,6 +17,15 @@
     "concurrently": "^8.2.1",
     "release-plan": "^0.8.0"
   },
+  "pnpm": {
+    "overrides_notes": {
+      "@glimmer/*": "https://github.com/glimmerjs/glimmer.js/issues/413"
+    },
+    "overrides": {
+      "@glimmer/validator": ">= 0.84.3",
+      "@glimmer/manager": ">= 0.84.3"
+    }
+  },
   "volta": {
     "node": "18.16.0",
     "pnpm": "8.7.6"