Improve types for some array internals #20086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
force-pushed
the
more-internals-ts3
branch
from
f8a90a1 to
8cf7538
Compare
wagenet
commented
May 6, 2022
wagenet
force-pushed
the
more-internals-ts3
branch
from
8cf7538 to
e63aed9
Compare
wagenet
commented
May 6, 2022
wagenet
force-pushed
the
more-internals-ts3
branch
from
e63aed9 to
af48a98
Compare
chriskrycho
reviewed
May 12, 2022
chriskrycho
reviewed
May 12, 2022
chriskrycho
reviewed
May 12, 2022
chriskrycho
reviewed
May 12, 2022
wagenet
force-pushed
the
more-internals-ts3
branch
from
af48a98 to
8c6a159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to tell in this diff, but some of the EmberArray types changed a little bit to be more accurate.