Fix LOG_VERSIONS and restore test suite coverage of real class field semantics #20867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef4
changed the title
Ember's debug logging of its own version was accidentally broken since 5.10 when we reformed the build. The problem was: - we switched to typescript's more spec-compliant class field semantics, where fields without `declare` are in fact present as real class fields with an undefined initializer. - our test suite was accidentally getting processed by vite's default (and pretty broken!) esbuild TS loader, which uses the loose & wrong field semantics. - `logVersions` in `class Libraries` is written in a picky way that breaks if you get the spec-compliant field semantics. This PR disables vite's built-in esbuild, which revealed the bug. The change to logVersions is the only real user-facing bugfix. There were also some similar bugs in the test suite itself which are fixed here. (All of this was precipated by me working on stable decorators, which *also* requires disabling vite's hidden-and-terrible TS support.)
ef4
force-pushed
the
fix-class-field-tests
branch
from
d111db3 to
fc11632
Compare
NullVoxPopuli
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember's debug logging of its own version was accidentally broken since 5.10 when we reformed the build.
The problem was:
declareare in fact present as real class fields with an undefined initializer.logVersionsinclass Librariesis written in a picky way that breaks if you get the spec-compliant field semantics.This PR disables vite's built-in esbuild, which revealed the bug.
The change to logVersions is the only real user-facing bugfix. There were also some similar bugs in the test suite itself which are fixed here.
(All of this was precipated by me working on stable decorators, which also requires disabling vite's hidden-and-terrible TS support.)