Skip to content

Commit d6d0090

Browse files
authored
Merge pull request #1010 from emberjs/achambers-patch-1
Update 0774-implicit-record-route-loading to include optional feature
2 parents 0572590 + 1715627 commit d6d0090

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

text/0774-implicit-record-route-loading.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ By removing this behaviour, we will encourage developers to explicitly define wh
4646

4747
We will issue a deprecation to [`findModel`](https://github.com/emberjs/ember.js/blob/017b11e2f58880869a5b8c647bf7f3199fc07f26/packages/%40ember/-internals/routing/lib/system/route.ts#L1376) notifying the user that if they want to continue this behaviour of attempting to fetch a resource implicitly, they should try and replicate with their own explicitly defined `model` hook.
4848

49-
In addition, we will include an [optional feature](https://github.com/emberjs/ember-optional-features) to disable this feature and clear the deprecation.
49+
In addition, we will include an [optional feature](https://github.com/emberjs/ember-optional-features) to disable this feature and clear the deprecation. This optional feature will be enabled in the blueprint because we want new apps to get this behaviour by default.
5050

51-
In v6.0.0, we will remove `findModel` and logic to determine arguments for this method. This will not remove returning the `transition` context when no `model` hook is defined.
51+
In v6.0.0, we will remove `findModel` and logic to determine arguments for this method. This will not remove returning the `transition` context when no `model` hook is defined. The optional feature will also be removed.
5252

5353
## How we teach this
5454

0 commit comments

Comments
 (0)