Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember inspector breaks when staticEmberSource is enabled #1575

Closed
Windvis opened this issue Aug 8, 2023 · 2 comments
Closed

Ember inspector breaks when staticEmberSource is enabled #1575

Windvis opened this issue Aug 8, 2023 · 2 comments

Comments

@Windvis
Copy link
Collaborator

Windvis commented Aug 8, 2023

It seems that when the staticEmberSource flag is enabled, all of the ember-source modules (besides ember/index) are no longer pushed into the loader.js system. This breaks the Ember inspector since it expects some of those modules to be available. It does have some fallbacks but those are more intended for older Ember versions so those don't work either.

Since the AMD environment is most likely going away in the future we probably want an alternative solution for the inspector.

(I'm opening the issue here since it's the new staticEmberSources flag that uncovered the problem, but it might be more suited in the ember source or ember-inspector repos.)

@Windvis Windvis changed the title Ember inspector breaks when staticEmberSources is enabled Ember inspector breaks when staticEmberSource is enabled Aug 8, 2023
@lifeart
Copy link
Collaborator

lifeart commented Aug 8, 2023

Here is minimal config to get ember-inspector working without amd modules: https://github.com/lifeart/demo-ember-vite/blob/master/src/config/inspector.ts

Note: window.Ember should be defined or imported from somewhere

@patricklx
Copy link
Contributor

This is mostly fixed by emberjs/ember-inspector#2475
Ember inspector can load, but some features like tracked detection and tracked dependencies will be missing

@Windvis Windvis closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants