Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog parsing on ignored packages (when PRs are either labeled or unlabeled) #60

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Mar 10, 2024

Resolves: embroider-build/create-release-plan-setup#91

Helps with: adopted-ember-addons/program-guidelines#28

Unblocks: NullVoxPopuli/limber#1673
As well as a few releases on the adopted ember addons org (I don't remember where now, but folks have arbitrarily been working around the problem by adding internal to their PRs -- so this is more a fix for a big annoyance than a fix for something show-stopping).

This seems to do what I want, however it looks like like we need to do further changelog filtering and not use @ef4/lerna-changelog's default output.

  • package list should exclude private packages
  • package groups should be combined since if just removing the string, we'd have duplicate package groups.

Alternate fix here: embroider-build/github-changelog#16 (which I think is he correct fix and we should not merge this (#60) PR)

Testing

In the root package.json:

"release-plan": "github:embroider-build/release-plan#dist/ignore-private-packages-detected-from-the-changelog-generator-dist"

or

"release-plan": "github:embroider-build/release-plan#bbd8d70"

Preview: NullVoxPopuli/limber#1673
image

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Mar 10, 2024
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review March 10, 2024 03:57
NullVoxPopuli added a commit to NullVoxPopuli/limber that referenced this pull request Mar 10, 2024
@NullVoxPopuli NullVoxPopuli reopened this Mar 10, 2024
@mansona
Copy link
Member

mansona commented Mar 11, 2024

I agree that the github-changelog fix is the right fix so let's put our effort over there to make it happen 👍

@mansona mansona closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private packgaes not ignored by changelog generation/preview
2 participants