Fix changelog parsing on ignored packages (when PRs are either labeled or unlabeled) #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: embroider-build/create-release-plan-setup#91
Helps with: adopted-ember-addons/program-guidelines#28
Unblocks: NullVoxPopuli/limber#1673
As well as a few releases on the adopted ember addons org (I don't remember where now, but folks have arbitrarily been working around the problem by adding
internal
to their PRs -- so this is more a fix for a big annoyance than a fix for something show-stopping).This seems to do what I want, however it looks like like we need to do further changelog filtering and not use
@ef4/lerna-changelog
's default output.Alternate fix here: embroider-build/github-changelog#16 (which I think is he correct fix and we should not merge this (#60) PR)
Testing
In the root package.json:
or
Preview: NullVoxPopuli/limber#1673
