Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: print more string values quoted #293

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Apr 27, 2024

Now below strings are quoted (although they are unquoted strings):

  1. Strings starts with digits, e.g. "12kb"
  2. Strings have . or -

This is to help other libs (such as golang) which have trouble parsing such values.

@zmstone zmstone requested a review from a team April 27, 2024 13:42
@zmstone zmstone merged commit a796199 into emqx:master Apr 28, 2024
3 checks passed
@zmstone zmstone deleted the 0427-hocon-pp-quote-string-with-dots branch April 28, 2024 12:03
zmstone added a commit to zmstone/emqx that referenced this pull request Apr 28, 2024
hocon pretty-print quotes more string values
if a string has '.' or '-', or if it starts with a digit 0-9,
then it's quoted.

see details here: emqx/hocon#293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants