-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Adds SDL3_ttf port #24601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adds SDL3_ttf port #24601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! lgtm % a couple of nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you forgot to add the new test to test_other.py
and test_browser.py
.
Good find, I was wondering how to add the tests to the runners. Added some more tests as well. |
The browser tests seem to be a hit or miss, unrelated to the code additions this PR is about? Any recommendation how to deal with that? I can keep retriggering until we get a pass, but that seems a bit wrong to me... |
No description provided.