Skip to content

Commit

Permalink
Merge branch 'develop' into feature/WRR-11077
Browse files Browse the repository at this point in the history
  • Loading branch information
juwonjeong committed Dec 3, 2024
2 parents 01f65c8 + 313bc48 commit 601600d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The following is a curated list of changes in the Enact sandstone module, newest

### Fixed

- `sandstone/Scroller` to focus properly when the spottable node is bigger than the size of viewport by voice control
- `sandstone/Scroller` to prevent the native scrolling behavior caused by keydown events when a popup is open

## [3.0.0-alpha.3] - 2024-12-02
Expand Down
4 changes: 2 additions & 2 deletions useScroll/useEvent.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import platform from '@enact/core/platform';
import {onWindowReady} from '@enact/core/snapshot';
import {clamp} from '@enact/core/util';
import Spotlight, {getDirection} from '@enact/spotlight';
import {getPositionTargetOnFocus} from '@enact/spotlight/src/container';
import {getDeepSpottableDescendants, getPositionTargetOnFocus} from '@enact/spotlight/src/container';
import {getRect} from '@enact/spotlight/src/utils';
import {getTargetByDirectionFromElement} from '@enact/spotlight/src/target';
import {constants} from '@enact/ui/useScroll';
Expand Down Expand Up @@ -449,7 +449,7 @@ const useEventVoice = (props, instances) => {

/* if the focused element is out of the viewport, find another spottable element in the viewport */
if (spotItemBounds[last] <= viewportBounds[first] || spotItemBounds[first] >= viewportBounds[last]) {
const nodes = Spotlight.getSpottableDescendants(scrollContainerNode.dataset.spotlightId);
const nodes = getDeepSpottableDescendants(scrollContainerNode.dataset.spotlightId);
for (let i = 0; i < nodes.length; i++) {
const nodeBounds = nodes[i].getBoundingClientRect();

Expand Down

0 comments on commit 601600d

Please sign in to comment.