Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Closes: #2702 Refs: #XXXX ## Description As shown by #2702: When tests are run under the vscode JavaScript Debug Terminal, every time that test spawns a subshell, extra noise appears on the stderr of that subshell, such as ``` Debugger attached.␊ - Waiting for the debugger to disconnect... ``` This seems symptomatic of a widespread assumption that other tools on the toolchain can inject extra output into the stderr of subshells without typically causing problems. The test framework code changed by this PR had defaulted both an absent `stdout` expectation and an absent `stderr` expectation to expecting the empty string. This PR changes the `stderr` default expectation to an regexp that accepts anything. This can still be overridden by an explicitly provided `stderr` expectation, including one explicitly expecting an empty string, so there is no loss of generality. Just a change in the default. ### Security Considerations This change will cause some tests to pass that might have otherwise failed. Some of these masked failures may have been symptoms of actual problems, rather than tool generated noise. This PR will mask such problems. ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations Because the #2702 bug this PR fixes is about a behavior seen under the vscode JavaScript Debug Terminal, I didn't see a way to write an automated test to check the fix under CI. Rather, I just verified the fix locally and interactively using vscode. ### Compatibility Considerations As mentioned in Security Considerations above, this PR may mask genuine errors that would have been flagged prior to this PR. ### Upgrade Considerations none
- Loading branch information