Fix: env0_environment should return an error when template_id update… (#1044)

* Feat: env0_environment should return an error when template_id update is not applied on an environment that is "Waiting for approval"

* modify

* approve-plan

Author: TomerHeber

env0/resource_environment.go

@@ -837,6 +837,19 @@ func deploy(d *schema.ResourceData, apiClient client.ApiClientInterface) diag.Di
 		return diag.FromErr(err)
 	}
 
+	// See: https://github.com/env0/terraform-provider-env0/issues/1005
+	// If the user requires approval for deployment, we cannot update the template_id.
+	if d.HasChange("template_id") {
+		environment, err := apiClient.Environment(d.Id())
+		if err != nil {
+			return diag.Errorf("could not get environment: %v", err)
+		}
+
+		if environment.RequiresApproval != nil && *environment.RequiresApproval {
+			return diag.Errorf("cannot update template_id when user requires approval for deployment. Please set 'approve_plan_automatically' to 'true' or avoid updating the 'template_id' field")
+		}
+	}
+
 	subEnvironments, err := getSubEnvironments(d)
 	if err != nil {
 		return diag.Errorf("failed to extract subenvrionments from resourcedata: %v", err)

env0/resource_environment_test.go

@@ -644,6 +644,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
 					mock.EXPECT().Environment(environment.Id).Times(1).Return(environment, nil),
 					mock.EXPECT().ConfigurationVariablesByScope(client.ScopeEnvironment, environment.Id).Times(1).Return(client.ConfigurationChanges{}, nil),
 					mock.EXPECT().ConfigurationSetsAssignments("ENVIRONMENT", environment.Id).Times(2).Return(nil, nil),
+					mock.EXPECT().Environment(environment.Id).Times(1).Return(environment, nil),
 					mock.EXPECT().EnvironmentDeploy(environment.Id, deployRequest).Times(1).Return(client.EnvironmentDeployResponse{
 						Id: "deployment-id",
 					}, nil),

tests/integration/012_environment/main.tf

@@ -87,12 +87,13 @@ resource "env0_environment" "move_environment" {
 }
 
 resource "env0_environment" "modify_template" {
-  depends_on          = [env0_template_project_assignment.assignment]
-  force_destroy       = true
-  name                = "environment-modify-template-${random_string.random.result}"
-  project_id          = env0_project.test_project.id
-  template_id         = var.second_run ? env0_template.template2.id : env0_template.template.id
-  prevent_auto_deploy = true
+  depends_on                 = [env0_template_project_assignment.assignment]
+  force_destroy              = true
+  name                       = "environment-modify-template-${random_string.random.result}"
+  project_id                 = env0_project.test_project.id
+  template_id                = var.second_run ? env0_template.template2.id : env0_template.template.id
+  prevent_auto_deploy        = true
+  approve_plan_automatically = true
 }