Merge pull request #379 from envato/viraptor/indent-error

Report a more explicit error on indentation issues

Author: viraptor

lib/stack_master/config.rb

@@ -112,6 +112,8 @@ def load_stacks(stacks)
       stacks.each do |region, stacks_for_region|
         region = Utils.underscore_to_hyphen(region)
         stacks_for_region.each do |stack_name, attributes|
+          raise ConfigParseError.new("Entry for stack #{stack_name} has no attributes") if attributes.nil?
+
           stack_name = Utils.underscore_to_hyphen(stack_name)
           stack_attributes = build_stack_defaults(region).deeper_merge!(attributes).merge(
             'region' => region,

spec/fixtures/stack_master_wrong_indent.yml

@@ -0,0 +1,4 @@
+stacks:
+  us-east-1:
+    myapp_vpc:
+    template: myapp_vpc.json

spec/stack_master/config_spec.rb

@@ -35,6 +35,13 @@
       end
     end
 
+    it "gives explicit error on badly indented entries" do
+      Dir.chdir('./spec/fixtures/') do
+        expect { StackMaster::Config.load!('stack_master_wrong_indent.yml') }
+          .to raise_error StackMaster::Config::ConfigParseError
+      end
+    end
+
     it "searches up the tree for stack master yaml" do
       begin
         orig_dir = Dir.pwd