Security refactor #871
Merged
Security refactor #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwalkerster
force-pushed
the
multiproject/local-access
branch
from
767924b to
a1393c9
Compare
stwalkerster
force-pushed
the
multiproject/local-access
branch
from
a1393c9 to
ef6c21d
Compare
stwalkerster
force-pushed
the
startup
branch
from
ccf8734 to
7ba5e31
Compare
stwalkerster
force-pushed
the
multiproject/local-access
branch
from
ef6c21d to
fc08d3f
Compare
stwalkerster
force-pushed
the
startup
branch
2 times, most recently
from
e042301 to
d364a3c
Compare
stwalkerster
force-pushed
the
multiproject/local-access
branch
from
fc08d3f to
3bfdde3
Compare
stwalkerster
force-pushed
the
multiproject/local-access
branch
2 times, most recently
from
04d3ff1 to
e116286
Compare
stwalkerster
force-pushed
the
multiproject/local-access
branch
from
e116286 to
b11ab67
Compare
stwalkerster
added
the
actually quite difficult
stwalkerster
force-pushed
the
multiproject/local-access
branch
from
b11ab67 to
9989485
Compare
stwalkerster
force-pushed
the
tos-privacy
branch
3 times, most recently
from
e15b888 to
3b01d66
Compare
This means RoleConfigurationBase is easily testable, and RoleConfiguration *only* holds the production configuration. Also, yay 100% test coverage on RoleConfigurationBase.
As a bonus, this gets us to 100% test coverage for SecurityManager
Plus associated refactoring.
stwalkerster
force-pushed
the
multiproject/local-access
branch
from
9989485 to
6fe0c74
Compare
dqwiki
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does a general refactor of our security, roles and identification code.
The overall goal of this refactor is to make the security code more testable via unit tests, and as a result this change also introduces a bunch more unit tests on the security code. We also make the "user" role implicit in this change, as there's no (current) need for this to be toggle-able.
As this is a change to the security code, please treat this as a risky change.