Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument "fields" to the get_prices function #28

Closed
rzhli opened this issue Jan 19, 2025 · 1 comment
Closed

Add argument "fields" to the get_prices function #28

rzhli opened this issue Jan 19, 2025 · 1 comment

Comments

@rzhli
Copy link
Contributor

rzhli commented Jan 19, 2025

If I am interested in specific column like low, and want only return that data, there should be an argument keyword like fileds allow me to achieve that.

It will be better if get_prices function add fields::Vector{String} like:

get_prices(symbol::String; range::String="5d", interval::String="1d", ..., divsplits::Bool=false, wait::Float64=0.0, fields::Vector{String})

where fields = ["Open", "High", "Low", "Close", "Adj Close"])

@eohne
Copy link
Owner

eohne commented Jan 19, 2025

The get request always returns all of these fields so I don't think there is much to be gained from having a fields argument.

Put differently having a fields argument is practically the same as just getting the dictionary from get prices and then taking the relevant columns from there.

@rzhli rzhli closed this as completed Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants