Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Version.variant_name attribute #120

Closed
7 tasks done
eoyilmaz opened this issue Nov 22, 2024 · 0 comments · Fixed by #124
Closed
7 tasks done

Remove Version.variant_name attribute #120

eoyilmaz opened this issue Nov 22, 2024 · 0 comments · Fixed by #124
Assignees
@eoyilmaz
Labels
enhancement
Milestone
1.0.0

Comments

@eoyilmaz
Copy link
Owner

eoyilmaz commented Nov 22, 2024 •
edited
Loading

User Story

As the developer of Stalker as we now have the Variant class implemented (#122) I want to remove the Version.variant_name so we should remove the confusion.

Acceptance Criteria

  • Update Version class:
    • Remove Version.variant_name attribute.
  • Create Alembic migration scripts:
    • Port existing data by creating a new Variant instance for each leaf task that has a Version relation.
    • Move all Version to this new class by setting Version.task_id to this new Variant.
    • Copy the Version.variant_name to the Variant.name attribute.
    • Drop the Versions.variant_name column.
@eoyilmaz eoyilmaz mentioned this issue Nov 22, 2024
Closed
1 task
@eoyilmaz eoyilmaz changed the title Update class Remove Version.variant_name attribute Nov 22, 2024
eoyilmaz added a commit that referenced this issue Nov 26, 2024
@eoyilmaz
[#120] Fix a variable name in stalker.models.review.Review.
f97a8e5
@eoyilmaz eoyilmaz mentioned this issue Nov 27, 2024
Closed
12 tasks
eoyilmaz added a commit that referenced this issue Nov 28, 2024
@eoyilmaz
[#120] Removed the Version.variant_name attribute.
d661679
eoyilmaz added a commit that referenced this issue Nov 28, 2024
@eoyilmaz
[#120] Fixed alembic revision with id 4400871fa852.
5f39d59
eoyilmaz added a commit that referenced this issue Dec 3, 2024
@eoyilmaz
[#120] Fixed alembic revision with id 91ed52b72b82 (which is about …
9072745 
…adding the Variant class) to also create a `StatusList` for `Variant` instances.
eoyilmaz added a commit that referenced this issue Dec 3, 2024
@eoyilmaz
[#120] Added alembic revision for the Version.variant_name column r…
24a1575 
…emoval. The data is now preserved on `Variant` instances.
eoyilmaz added a commit that referenced this issue Dec 4, 2024
@eoyilmaz
- [#120] Updated a windows specific test to run on all OSes.
cbc9348 
- [#120] Updated code formatting.
- [#120] Updated `CHANGELOG.rst` with more recent changes.
eoyilmaz added a commit that referenced this issue Dec 4, 2024
@eoyilmaz
[#120] Fix a variable name in stalker.models.review.Review.
4a85ef0
eoyilmaz added a commit that referenced this issue Dec 4, 2024
@eoyilmaz
[#120] Removed the Version.variant_name attribute.
b77d324
eoyilmaz added a commit that referenced this issue Dec 4, 2024
@eoyilmaz
[#120] Fixed alembic revision with id 4400871fa852.
48ae9e4
eoyilmaz added a commit that referenced this issue Dec 4, 2024
@eoyilmaz
[#120] Fixed alembic revision with id 91ed52b72b82 (which is about …
7a2ddc9 
…adding the Variant class) to also create a `StatusList` for `Variant` instances.
eoyilmaz added a commit that referenced this issue Dec 4, 2024
@eoyilmaz
[#120] Added alembic revision for the Version.variant_name column r…
c64f63b 
…emoval. The data is now preserved on `Variant` instances.
eoyilmaz added a commit that referenced this issue Dec 4, 2024
@eoyilmaz
- [#120] Updated a windows specific test to run on all OSes.
f8ef87a 
- [#120] Updated code formatting.
- [#120] Updated `CHANGELOG.rst` with more recent changes.
@eoyilmaz eoyilmaz linked a pull request Dec 4, 2024 that will close this issue
120 remove versionvariant name attribute #124
Merged
eoyilmaz added a commit that referenced this issue Dec 4, 2024
@eoyilmaz
[#120] Fix database url in alembic.ini.
7d95e8d
@eoyilmaz eoyilmaz added this to the 1.0.0 milestone Dec 4, 2024
@eoyilmaz eoyilmaz self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eoyilmaz eoyilmaz

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

120 remove versionvariant name attribute eoyilmaz/stalker
1 participant
@eoyilmaz