Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Review.version attribute #121

Closed
10 tasks done
eoyilmaz opened this issue Nov 22, 2024 · 0 comments · Fixed by #123
Closed
10 tasks done

Add Review.version attribute #121

eoyilmaz opened this issue Nov 22, 2024 · 0 comments · Fixed by #123
Milestone

Comments

@eoyilmaz
Copy link
Owner

eoyilmaz commented Nov 22, 2024

User Story

As a supervisor I want know which Version of a Task I'm reviewing so that when I approve the Task I now that I approved a certain Version along with the Task.

Acceptance Criteria

  • Add a new column to Review class which holds the Version relation (Review.version and Review.version_id).
  • Update Review.__init__() to accept a Version instance with the version argument.
  • Add a _validate_version method:
    • Validates the Version instance.
    • Check if the Version.task is matching Review.task.
  • Update Task class:
    • Update Task.request_review to accept a Version instance.
    • Add a new request_review method for the Version class that calls the Version.task.request_review() and attaches itself to the review.
  • Add Alembic migration scripts:
    • Add the Reviews.version_id column.
@eoyilmaz eoyilmaz mentioned this issue Nov 22, 2024
1 task
@eoyilmaz eoyilmaz changed the title Update class Add Review.version attribute Nov 22, 2024
eoyilmaz added a commit that referenced this issue Nov 26, 2024
- [#121] Added `Version.reviews` mapped column.
- [#121] Added `Version.request_review()` which is a shortcut to the `request_review` method in the related `Task` instance.
@eoyilmaz eoyilmaz linked a pull request Nov 26, 2024 that will close this issue
eoyilmaz added a commit that referenced this issue Nov 26, 2024
@eoyilmaz eoyilmaz added this to the 1.0.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant