Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Project.is_active attribute. #74

Closed
3 tasks
eoyilmaz opened this issue Feb 9, 2023 · 0 comments · Fixed by #115
Closed
3 tasks

Remove Project.is_active attribute. #74

eoyilmaz opened this issue Feb 9, 2023 · 0 comments · Fixed by #115
Assignees
Milestone

Comments

@eoyilmaz
Copy link
Owner

eoyilmaz commented Feb 9, 2023

User Story

As a developer using Stalker I want to convert the Project.is_active attribute from being a column in the database to a property returning if the Project.status is Complete/CMPL or not to make it lean and remove confusion.

Acceptance Criteria

  • 1. Remove the is_active column definition from the Project class.
  • 2. Add an Alembic migration script for this.
  • 3. Add a new is_active predicate property that returns if the Project.status is Status=Complete/CMPL which is one of the default statuses created by Stalker configurations.

Notes

This attribute has never been used since it is ever introduced, the status "Complete/CMPL" does the job beautifully, so remove the is_active attribute.

@eoyilmaz eoyilmaz added this to the 1.0.0 milestone Feb 9, 2023
@eoyilmaz eoyilmaz self-assigned this Feb 9, 2023
eoyilmaz added a commit that referenced this issue Nov 18, 2024
…`Project.is_active` property is now checking if the `Project.status` is `WIP` or not.
eoyilmaz added a commit that referenced this issue Nov 18, 2024
…`Project.is_active` property is now checking if the `Project.status` is `WIP` or not.
eoyilmaz added a commit that referenced this issue Nov 18, 2024
…ibute

[#74] Removed `Project.active` attribute and the related column. The …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant