discojs-core/client/federated: rm SendMetadata

Author: tharvik

discojs/discojs-core/src/client/federated/messages.ts

@@ -9,7 +9,6 @@ export type MessageFederated =
   ReceiveServerPayload |
   RequestServerStatistics |
   ReceiveServerStatistics |
-  SendMetadata |
   ReceiveServerMetadata |
   AssignNodeID
 
@@ -30,14 +29,6 @@ export interface ReceiveServerStatistics {
   type: type.ReceiveServerStatistics
   statistics: Record<string, number>
 }
-export interface SendMetadata {
-  type: type.SendMetadata
-  nodeId: string
-  taskId: string
-  round: number
-  key: MetadataKey
-  value: MetadataValue
-}
 export interface ReceiveServerMetadata {
   type: type.ReceiveServerMetadata
   nodeId: client.NodeID
@@ -63,8 +54,6 @@ export function isMessageFederated (raw: unknown): raw is MessageFederated {
       return true
     case type.ReceiveServerStatistics:
       return true
-    case type.SendMetadata:
-      return true
     case type.ReceiveServerMetadata:
       return true
     case type.AssignNodeID:

discojs/discojs-core/src/client/messages.ts

@@ -16,7 +16,6 @@ export enum type {
 
   // Federated
   SendPayload,
-  SendMetadata,
   ReceiveServerMetadata,
   ReceiveServerPayload,
   RequestServerStatistics,

server/src/router/federated/server.ts

@@ -262,18 +262,6 @@ export class Federated extends Server {
         }
 
         this.createPromiseForWeights(task.id, aggregator, ws)
-      } else if (msg.type === MessageTypes.SendMetadata) {
-        const { round, key, value } = msg
-
-        this.logsAppend(task.id, clientId, MessageTypes.SendMetadata, round)
-
-        if (this.metadataMap.hasIn([task, round, clientId, key])) {
-          throw new Error('metadata already set')
-        }
-        this.metadataMap = this.metadataMap.setIn(
-          [task, round, clientId, key],
-          value
-        )
       } else if (msg.type === MessageTypes.ReceiveServerMetadata) {
         const { key, round } = msg