Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix missing dep in image #876

Merged
merged 2 commits into from
Feb 18, 2025
Merged

docker: fix missing dep in image #876

merged 2 commits into from
Feb 18, 2025

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented Feb 17, 2025

after #875, look like it failed to deploy the server, saying that it misses a dep. fixing it by removing code 🥇
also adding a CI step to try to avoid that.

@tharvik tharvik marked this pull request as ready for review February 17, 2025 23:00
@tharvik tharvik requested a review from JulienVig February 17, 2025 23:01
Copy link
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Why move with_server's content into lint-test-build?

@JulienVig JulienVig merged commit 4c6d97e into develop Feb 18, 2025
23 checks passed
@JulienVig JulienVig deleted the fix-docker-image branch February 18, 2025 07:27
@tharvik
Copy link
Collaborator Author

tharvik commented Feb 18, 2025

Why move with_server's content into lint-test-build?

it has been unused for a while and the new test in the CI is pretty much doing the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants