Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of participant inconsistency #895

Merged
merged 5 commits into from
Apr 1, 2025
Merged

Conversation

JulienVig
Copy link
Collaborator

Fixes #894 identified by @christinakopi.

We used to update the number of participants only during weight sharing. I made a few changes to update the participants more frequently (doesn't cover every case yet):

  • Client emits a participants event (which is forwarded by Disco) that the webapp can watch
  • The server now sends the number of participants at connection, in WaitForMoreParticipants messages and in EnoughParticipants messages
  • With tests©
  • The number of participants is not dynamically updated when clients are waiting for more participants, it stays fixed until enough participants joined and the training can start (we can implement a new message type to update clients when a new client joins).

@JulienVig JulienVig requested a review from tharvik March 13, 2025 14:56
@JulienVig JulienVig self-assigned this Mar 13, 2025
Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haa, works flawlessly, niceux!

@JulienVig JulienVig force-pushed the 894-participant-julien branch 3 times, most recently from c3012ef to 4d276ba Compare March 31, 2025 13:25
@JulienVig JulienVig force-pushed the 894-participant-julien branch from 4d276ba to f8a5762 Compare April 1, 2025 10:14
@JulienVig JulienVig merged commit 6c05519 into develop Apr 1, 2025
22 of 23 checks passed
@JulienVig JulienVig deleted the 894-participant-julien branch April 1, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of participant is inconsistent during training
2 participants