test GPT layers #899
Open
test GPT layers #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharvik
force-pushed
the
NAN-layers_tests-christinakopi
branch
from
d6b7ad1 to
05ce66f
Compare
tharvik
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
haa thanks for shedding some light on the dark corners of GPT! some style comments but nothing blocking.
note that I wasn't able to check for the layers implementations as it is still magical to me but as long as the "gpt-tfjs can overfit one sentence" test is green, sounds good!
also, I rebased your branch to update it with the latest develop changes (which also fixes the CI error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.