Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 35: Add hex sticker #36

Merged
merged 4 commits into from
May 15, 2024
Merged

Issue 35: Add hex sticker #36

merged 4 commits into from
May 15, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented May 14, 2024 •
edited
Loading

Description

This PR closes #35.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

seabbs
seabbs previously approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🎈. Can you just deal with the linting issues (click on details for the failing check) and then this is good to go.

@athowes
Copy link
Collaborator Author

athowes commented May 15, 2024

I've fixed the linting, and also removed the URL from the logo (I think this is the right move, URL doesn't really add anything IMO and is something extra to maintain -- I'll do the same for the epinowcast logo on the other PR).

@seabbs seabbs added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 53f81f9 May 15, 2024
3 checks passed
@seabbs seabbs deleted the add-sticker branch May 15, 2024 12:20
seabbs pushed a commit that referenced this pull request Jan 10, 2025
@athowes
Issue 35: Add hex sticker (#36)
b1a60c4 
* Add code to generate hex sticker and resulting .png file

* Fix linting issues

* Remove URL from logo

* Regenerate logo

Former-commit-id: ca1f5a61cfce711e0accf3105a9926a80d88ad8f [formerly 2de0e9ae3e27de225db0c31756e5f2b29c5edc7a]
Former-commit-id: 9315319cf36f28246dabb88421d4f14b752f40d7
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 35: Add hex sticker (#36)
1d5d1a8 
* Add code to generate hex sticker and resulting .png file

* Fix linting issues

* Remove URL from logo

* Regenerate logo

Former-commit-id: 53f81f9
Former-commit-id: 3bf0b0095eda70299023a00e38fce83fff14ecd7
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 35: Add hex sticker (#36)
95939ed 
* Add code to generate hex sticker and resulting .png file

* Fix linting issues

* Remove URL from logo

* Regenerate logo

Former-commit-id: 53f81f9
Former-commit-id: 3bf0b0095eda70299023a00e38fce83fff14ecd7
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 35: Add hex sticker (#36)
1235ce3 
* Add code to generate hex sticker and resulting .png file

* Fix linting issues

* Remove URL from logo

* Regenerate logo

Former-commit-id: 53f81f9
Former-commit-id: 3bf0b0095eda70299023a00e38fce83fff14ecd7
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 35: Add hex sticker (#36)
e1b67c2 
* Add code to generate hex sticker and resulting .png file

* Fix linting issues

* Remove URL from logo

* Regenerate logo

Former-commit-id: ca1f5a61cfce711e0accf3105a9926a80d88ad8f [formerly 2de0e9ae3e27de225db0c31756e5f2b29c5edc7a]
Former-commit-id: 9315319cf36f28246dabb88421d4f14b752f40d7
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 35: Add hex sticker (#36)
2fcd735 
* Add code to generate hex sticker and resulting .png file

* Fix linting issues

* Remove URL from logo

* Regenerate logo

Former-commit-id: ca1f5a61cfce711e0accf3105a9926a80d88ad8f [formerly 2de0e9ae3e27de225db0c31756e5f2b29c5edc7a]
Former-commit-id: 9315319cf36f28246dabb88421d4f14b752f40d7
Former-commit-id: e1b67c2
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 35: Add hex sticker (#36)
59a3f8a 
* Add code to generate hex sticker and resulting .png file

* Fix linting issues

* Remove URL from logo

* Regenerate logo

Former-commit-id: 53f81f9
Former-commit-id: 3bf0b0095eda70299023a00e38fce83fff14ecd7
Former-commit-id: f74588ced1e81bc607762f3d29f3ca029a1ffe66 [formerly 1235ce3]
Former-commit-id: 60387fe7f3520e178dce59c036787235764333ef
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 35: Add hex sticker (#36)
f0a0ed5 
* Add code to generate hex sticker and resulting .png file

* Fix linting issues

* Remove URL from logo

* Regenerate logo

Former-commit-id: 53f81f9
Former-commit-id: 3bf0b0095eda70299023a00e38fce83fff14ecd7
Former-commit-id: f74588ced1e81bc607762f3d29f3ca029a1ffe66 [formerly 1235ce3]
Former-commit-id: 60387fe7f3520e178dce59c036787235764333ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing a hex sticker
2 participants
@athowes @seabbs