-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update figures in vignettes #55
Comments
I think the question for at least the getting started vignette is if we have a package plot that does the same function and are not using it should we keep the function. I don't think reviewing which plots to keep is out of scope. |
I agree. As part of this issue we should:
|
I think we should have a clear inventory of what plotting the package currently has (maybe here) and discuss |
We do not currently intend to include plots in this package so I think we can close this issue. |
The figures in the vignettes are currently generated from scratch and do not follow the same theme as the figure functions in the package and associated paper(s).
We should definitely standardise the style.
We should decide on whether to use "from scratch" plots in our vignettes or package plots.
Further, we should review which plots there are the in package and which we want to keep. In some sense this is part of a broader issue, so perhaps that's out of scope for this issue.
The text was updated successfully, but these errors were encountered: