Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update figures in vignettes #55

Closed
athowes opened this issue May 23, 2024 · 4 comments
Closed

Update figures in vignettes #55

athowes opened this issue May 23, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@athowes
Copy link
Collaborator

athowes commented May 23, 2024

The figures in the vignettes are currently generated from scratch and do not follow the same theme as the figure functions in the package and associated paper(s).

We should definitely standardise the style.

We should decide on whether to use "from scratch" plots in our vignettes or package plots.

Further, we should review which plots there are the in package and which we want to keep. In some sense this is part of a broader issue, so perhaps that's out of scope for this issue.

@athowes athowes added the documentation Improvements or additions to documentation label May 23, 2024
@seabbs
Copy link
Contributor

seabbs commented May 23, 2024

We should decide on whether to use "from scratch" plots in our vignettes or package plots.

I think the question for at least the getting started vignette is if we have a package plot that does the same function and are not using it should we keep the function. I don't think reviewing which plots to keep is out of scope.

@athowes athowes self-assigned this May 30, 2024
@athowes
Copy link
Collaborator Author

athowes commented Jul 15, 2024

I agree. As part of this issue we should:

  • Replace uses of handwritten plotting functions in the get started vignette with packaged versions OR delete packaged version
  • Make any alterations to packaged versions

@seabbs
Copy link
Contributor

seabbs commented Jul 15, 2024

I think we should have a clear inventory of what plotting the package currently has (maybe here) and discuss

@athowes athowes mentioned this issue Jul 30, 2024
18 tasks
@athowes athowes removed their assignment Aug 8, 2024
@athowes
Copy link
Collaborator Author

athowes commented Nov 20, 2024

We do not currently intend to include plots in this package so I think we can close this issue.

@athowes athowes closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants