-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand getting started vignette #9
Comments
Yes I agree though the minor push back is that getting started vignettes do typically need to be short so some of the suggested content my work better in secondary or tertiary vignettes. |
Suggest focusing this "Get started" vignette on clearly explaining use of the one (or perhaps two) primary modelling functions we select (see #15). Suggests a natural additional vignette with comparison to approaches we don't think are very good (currently implemented in function code, but once deprecated can be implemented in raw |
agree sounds like a good idea. |
Rewriting this first "Get started" vignette with just the Based on these considerations, this is what I'm going to start working on now. |
In my view the "Getting started" vignette should be minimal and focus on:
|
I like the idea of moving data simulation into its own vignette. Also want to point out that it's considered a best practice to include a separate data generation script in the /data subdirectory for reproducibility: https://r-pkgs.org/data.html |
Posterior predictive check in the getting started vignette or another one? Look at simulate double censored PMF function in |
I did think about having test data generated and stored within the package, and then pulling that into the first vignette. However, I think as we want to have the simulation conditions available for comparison it doesn't make sense to do that, and we should just have it be simulated in the vignette (just low light it). That said, I still think it could be good to have test data generated and available for use with package tests. |
The reason. to simulate the censoring process in the vignette is to try and give people some visibility about what the observation process that is happening is with the hope they can maybe understand it. Now we have more papers trying to do this it seems like less of a priority but IMO is still a good idea as long as it doesn't take up too much space vs the rest of the getting started. |
Yes agree it's a good idea to have the simulation in. A user hopefully should read the vignette and know better "what is censoring" and "what is truncation" than when they started. I think we can go a good way towards achieving that. |
The
epidist
vignette is quite compact and possibly difficult to read for users not familiar with the package and methods already. I suggest expanding the writing to make it easier for new users to follow. The scope of this work would be to add further descriptions, links and references, figures, tables to the getting started vignette.The text was updated successfully, but these errors were encountered: